After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770291 - rtpsession: Add property "stats-min-interval"
rtpsession: Add property "stats-min-interval"
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-23 17:52 UTC by Håvard Graff (hgr)
Modified: 2018-11-03 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.38 KB, patch)
2016-08-23 17:52 UTC, Håvard Graff (hgr) 		none Details | Review

Description Håvard Graff (hgr) 2016-08-23 17:52:26 UTC 
Created attachment 334026 [details] [review]
patch

Add property to throttle the rate at which rtpsession notifies about
"stats".

With any incoming RTCP potentially triggering this callback, things like RTX and APP messages might effectively spam you with stats, so this is a simple mechanism to make sure they are throttled.
Comment 1 Olivier Crête 2016-08-23 19:04:03 UTC 
Review of attachment 334026 [details] [review]:

Is the signal callback machnism in itself so costly that you need this?!
Comment 2 Håvard Graff (hgr) 2016-08-23 19:07:13 UTC 
(In reply to Olivier Crête from comment #1)
> Review of attachment 334026 [details] [review] [review]:
> 
> Is the signal callback machnism in itself so costly that you need this?!

Well no, but you can easily get >10 per second if you are doing RTX towards Chrome, and if your stats are being handling by an application, that is a lot of unnecessary updates. Add GI python-binding and a few more sessions, and you have yourself an application staller.
Comment 3 Sebastian Dröge (slomo) 2016-11-04 14:56:09 UTC 
RTX and APP packets should not affect those stats though, only RR/SRs do? Or not?
Comment 4 GStreamer system administrator 2018-11-03 15:10:59 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/292.