After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770270 - Plural support for new compressing/extracting strings
Plural support for new compressing/extracting strings
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Internationalization (i18n)
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-23 10:02 UTC by Piotr Drąg
Modified: 2016-08-23 12:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
file-undo-operations: add plural support for strings (2.46 KB, patch)
2016-08-23 10:28 UTC, Razvan Chitu 		committed Details | Review

Description Piotr Drąg 2016-08-23 10:02:34 UTC 
Several new strings for compressing/extracting in src/nautilus-file-undo-operations.c need plural handling, as they have variable numbers.

https://wiki.gnome.org/TranslationProject/DevGuidelines/Plurals

Also, I don't think "Compress '%d' files" should have '' in it, it doesn't seem to be a file name.
Comment 1 Razvan Chitu 2016-08-23 10:28:48 UTC 
Created attachment 333983 [details] [review]
file-undo-operations: add plural support for strings

The compression and extraction undo / redo strings lacked plural support.
Comment 2 Carlos Soriano 2016-08-23 11:03:41 UTC 
Review of attachment 333983 [details] [review]:

LGTM

thanks Piotr for keeping an eye, and Razvan for being fast on fixing it :)
Comment 3 Razvan Chitu 2016-08-23 12:46:42 UTC 
Attachment 333983 [details] pushed as c81d968 - file-undo-operations: add plural support for strings