After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770269 - Recent scrolled window changes are causing the panel to unexpectedly expand
Recent scrolled window changes are causing the panel to unexpectedly expand
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Search
git master
Other Linux
: Normal normal
: ---
Assigned To: Cosimo Cecchi
Control-Center Maintainers
Depends on: 766569
Blocks:
 
 
Reported: 2016-08-23 09:32 UTC by Felipe Borges
Modified: 2016-08-31 19:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (90.36 KB, image/png)
2016-08-23 09:32 UTC, Felipe Borges 		  Details
search: Prevent the scrolled window from expanding the panel (1.28 KB, patch)
2016-08-23 10:21 UTC, Felipe Borges 		reviewed Details | Review

Description Felipe Borges 2016-08-23 09:32:08 UTC 
Created attachment 333979 [details]
screenshot

This bug can be reproduced after commit 13b745aa3df77c347a98ae8b2ef137ed8bc20483, which bumped the Gtk+ version to a version after the changes in GtkScrolledWindow discussed at Bug 766569.

The following patch can be reverted after there's an API change on Gtk+ size.
Comment 1 Felipe Borges 2016-08-23 10:21:17 UTC 
Created attachment 333982 [details] [review]
search: Prevent the scrolled window from expanding the panel

Since the GtkScrolledWindow changes introduced in bgo#766569, the
Search panel is unexpectedly expading vertically. Since there's
still no concensus in whether there will be new API to cover the
cases where we don't want GtkScrolledWindow to report its child
natural width/height, this patch arbitrarialy sets the widget's
"max-content-height" property to an arbitrary number.
Comment 2 Cosimo Cecchi 2016-08-29 20:53:24 UTC 
Review of attachment 333982 [details] [review]:

It's not clear to me that this is the right way to go. It feels that what the UI definition is doing here is perfectly legitimate and should not break...
So I'd rather get some closure on the GTK bug before we go one way or the other here.