After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770262 - Rhythmbox GIR Bindings Broken With 3.4 (rb_application_add_accelerator)
Rhythmbox GIR Bindings Broken With 3.4 (rb_application_add_accelerator)
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Programmatic interfaces
3.4
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-23 05:43 UTC by Ikey Doherty
Modified: 2016-08-24 17:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rb-application: Ensure paramater nullability is known to bindings (1.23 KB, patch)
2016-08-23 05:43 UTC, Ikey Doherty 		committed Details | Review

Description Ikey Doherty 2016-08-23 05:43:20 UTC 
Created attachment 333973 [details] [review]
rb-application: Ensure paramater nullability is known to  bindings

TL;DR The "variant" parameter isn't nullable in rb_application_add_accelerator, and Python dies when trying to invoke it with 'None'

Noticed in rhythmbox alternative-toolbar: https://github.com/fossfreedom/alternative-toolbar
Comment 1 Jonathan Matthew 2016-08-24 12:16:47 UTC 
Review of attachment 333973 [details] [review]:

pushed as commit 50fb6ff, thanks
Comment 2 Ikey Doherty 2016-08-24 17:05:21 UTC 
Thanks for merging so quickly :)