GNOME Bugzilla – Bug 770202
GstStream, GstStreamCollection: what about global tags ?
Last modified: 2018-11-03 12:35:51 UTC
So GstStream stores the stream tags for a stream, which makes sense. Question is whether we should also put the global tags somewhere. Perhaps they should be put into the collection? (and merged if there are multiple differing ones) +++ This bug was initially created as a clone of Bug #770053 +++
I think storing it in the stream collection is not ideal, unless you store it in another "container" struct like GstStream that allows modifications. The stream collection is immutable, the streams are not (details can be added e.g.). And the (global) tags are similar in this regard, they could be updated along the way or even by the same element later. However conceptually it seems to belong into the stream collection, so maybe we indeed need some kind of GstStreamGlobalTags that is reference counted, properly locked, and allows setting/getting taglists.
Or GstStreamCollectionDetails, to keep it more generic. One might want to add other things in there at a later time.
It could of course also just be a getter/setter for the taglist itself. While the streams array in the collection is supposed to be immutable (i.e. no new streams added/removed), the streams themselves can change. And allowing a taglist to be changed in the collection (in a thread-safe way) is not very different in that regard. The important part about the immutability here is that streams don't appear or disappear.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/185.