After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770193 - Some newer CSS units / dimensions are not highlighted
Some newer CSS units / dimensions are not highlighted
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
3.19.x
Other All
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-21 11:04 UTC by Tobias Schönberg
Modified: 2016-08-21 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
css.lang: Add support for some newer CSS units / dimensions (1.12 KB, patch)
2016-08-21 11:28 UTC, Tobias Schönberg 		accepted-commit_now Details | Review

Description Tobias Schönberg 2016-08-21 11:04:40 UTC 
Some newer CSS units / dimensions (e.g. rem, vh, vw) are not highlighted at the moment. I will attach a patch.
Comment 1 Tobias Schönberg 2016-08-21 11:28:16 UTC 
Created attachment 333805 [details] [review]
css.lang: Add support for some newer CSS units / dimensions

Currently the units 'vh', 'vw', 'vmin', 'vmax', 'ch', 'rem'
are not highlighted with the same color as e.g. '10px'.
This commit updates the 'dimension' context to fix the issue.
Comment 2 Sébastien Wilmet 2016-08-21 17:36:21 UTC 
Review of attachment 333805 [details] [review]:

Looks good, thanks.
Comment 3 Sébastien Wilmet 2016-08-21 17:51:28 UTC 
Pushed.