After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770167 - "View All" button in iRadio plugin doesn't fire filter changed notification
"View All" button in iRadio plugin doesn't fire filter changed notification
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Internet Radio
3.4
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-20 11:44 UTC by gnome.vrb
Modified: 2016-08-20 22:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description gnome.vrb 2016-08-20 11:44:01 UTC 
Steps to reproduce:

1. Enter "++++" in GtkEntry ( Search your Internet Radio Stations )
2. All stations ( should possibly ) disappear.
3. Click "View All" button.

Text is cleared, but no radio stations are displayed.
Comment 1 gnome.vrb 2016-08-20 11:52:13 UTC 
I'm not sure if "View All" button ( in Music / Radio / Podcast ) still makes much sense. It offers very little for a button in that spot. Sometimes, it is confusing to use it with 'Browse' button ( 2 buttons offering view related functionality ). Removing the 'View All' button would add more clarity to 'Browse' button.

Now that GtkSearchEntry has been available for some time, users of Gnome / GTK would well be aware of how to use the search bar, and would not be needing "View All" button anymore.
Comment 2 Jonathan Matthew 2016-08-20 22:01:52 UTC 
(In reply to vrishab from comment #1)

> Now that GtkSearchEntry has been available for some time, users of Gnome /
> GTK would well be aware of how to use the search bar, and would not be
> needing "View All" button anymore.

The 'view all' button clears both the browser selection and the search bar, which you cannot do with just the search bar, so this wouldn't work.
Comment 3 Jonathan Matthew 2016-08-20 22:10:24 UTC 
The actual bug here was that the property view wasn't selecting the 'all' row when the selection was cleared, so it didn't emit a selection-changed notification, so the iradio source didn't rerun its query.  Commit 70495e6 fixes this.