Bug 770013 - gs-browse-web: Opt Debian and Ubuntu in to Firefox version
gs-browse-web: Opt Debian and Ubuntu in to Firefox version
Status: RESOLVED FIXED
Product: gnome-getting-started
Classification: Applications
Component: general
git master
Other All
: Normal normal
: git master
Assigned To: gnome-getting-started-maint
gnome-getting-started-maint
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2016-08-16 23:40 UTC by Jeremy Bicha
Modified: 2016-08-19 18:33 UTC (History)
2 users (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
gs-browse-web: Opt Debian and Ubuntu in to Firefox version (967 bytes, patch)
2016-08-16 23:40 UTC, Jeremy Bicha 		none Details | Diff | Review
gs-browse-web: Opt Debian and Ubuntu in to Firefox version (1.39 KB, patch)
2016-08-17 17:33 UTC, Jeremy Bicha 		committed Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Jeremy Bicha 2016-08-16 23:40:52 UTC 
Debian and Ubuntu GNOME both use Firefox by default and do not intend to
switch to Epiphany in the near future.
Comment 1 Jeremy Bicha 2016-08-16 23:40:58 UTC 
Created attachment 333443 [details] [review]
gs-browse-web: Opt Debian and Ubuntu in to Firefox version
Comment 2 Petr Kovar 2016-08-17 10:07:40 UTC 
Review of attachment 333443 [details] [review]:

Thanks for the patch, Jeremy. Just a nit, I think ubuntu and debian should also be added here:

<if:if test="platform:gnome-classic, platform:fedora, platform:rhel, platform:centos">

    <media its:translate="no" type="image" mime="image/svg"
    src="gs-web-browser2-firefox.svg" width="100%" />
Comment 3 Jeremy Bicha 2016-08-17 17:33:04 UTC 
Created attachment 333512 [details] [review]
gs-browse-web: Opt Debian and Ubuntu in to Firefox version
Comment 4 Petr Kovar 2016-08-19 15:55:36 UTC 
Review of attachment 333512 [details] [review]:

Looks good, thank you!
Comment 5 Jeremy Bicha 2016-08-19 18:33:03 UTC 
Attachment 333512 [details] pushed as aacb712 - gs-browse-web: Opt Debian and Ubuntu in to Firefox version
Note You need to log in before you can comment on or make changes to this bug.