GNOME Bugzilla – Bug 770004
Drop the runners when quitting a game
Last modified: 2016-08-17 18:56:46 UTC
When a game runner can save its state we can drop the runner safely and when a runner can't save the state we shouldn't keep the runner as its state when coming back is uncertain. We should check how command based games work though.
Created attachment 333517 [details] [review] ui: Split ApplicationWindow.run_game_with_cancellable() This make it more readable and hence maintainable.
Created attachment 333518 [details] [review] ui: Don't store runners anymore in ApplicationWindow This avoids keeping unused runners, which is useless, make use of more memory.
Created attachment 333519 [details] [review] retro: Deinit RetroRunner when it is stopped This will be used in the next commit to release memory when a game will stop being used.
Created attachment 333520 [details] [review] core: Add Runner.stop () Also implement it in the remaining runners. This will be used in the next commit to explicitly stop a runner when its game is quitted.
Created attachment 333521 [details] [review] ui: Stop runners when quitting the game This allows to release the Libretro cores when quitting a game.
Attachment 333517 [details] pushed as f60edd7 - ui: Split ApplicationWindow.run_game_with_cancellable() Attachment 333518 [details] pushed as a0fdd3f - ui: Don't store runners anymore in ApplicationWindow Attachment 333519 [details] pushed as 18b76ad - retro: Deinit RetroRunner when it is stopped Attachment 333520 [details] pushed as 1871d6b - core: Add Runner.stop () Attachment 333521 [details] pushed as fa09f20 - ui: Stop runners when quitting the game