After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769963 - ui: Useless TrackerGameSource in Application.load_game_list()
ui: Useless TrackerGameSource in Application.load_game_list()
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-16 06:01 UTC by Adrien Plazas
Modified: 2016-08-16 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ui: Remove useless source in Application (960 bytes, patch)
2016-08-16 06:06 UTC, Adrien Plazas 		none Details | Review
ui: Remove useless source in Application (960 bytes, patch)
2016-08-16 06:09 UTC, Adrien Plazas 		committed Details | Review
ui: Remove unused 'connection' prop in Application (1.05 KB, patch)
2016-08-16 06:09 UTC, Adrien Plazas 		committed Details | Review

Description Adrien Plazas 2016-08-16 06:01:40 UTC 
This code does nothing ass we don't add any query:
	if (connection == null)
		return;

	var tracker_source = new TrackerGameSource (connection);

	yield tracker_source.each_game (add_game);
Comment 1 Adrien Plazas 2016-08-16 06:06:37 UTC 
Created attachment 333389 [details] [review]
ui: Remove useless source in Application

This removes a TrackerGameSource from Application.load_game_list() which
is useless as we never set queries to it.
Comment 2 Adrien Plazas 2016-08-16 06:09:23 UTC 
Created attachment 333390 [details] [review]
ui: Remove useless source in Application

This removes a TrackerGameSource from Application.load_game_list() which
is useless as we never set queries to it.
Comment 3 Adrien Plazas 2016-08-16 06:09:29 UTC 
Created attachment 333391 [details] [review]
ui: Remove unused 'connection' prop in Application
Comment 4 Adrien Plazas 2016-08-16 14:28:49 UTC 
Attachment 333390 [details] pushed as 17b7c9b - ui: Remove useless source in Application
Attachment 333391 [details] pushed as 4665075 - ui: Remove unused 'connection' prop in Application