Bug 769897 – Crash during discarding unstaged changes on empty list

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 769897 - Crash during discarding unstaged changes on empty list


Summary:	Crash during discarding unstaged changes on empty list


Status:	RESOLVED FIXED

Product:	gitg
Classification:	Applications
Component:	gui
Version:	git master
Hardware:	Other Linux

Importance:	Normal major
Target Milestone:	---
Assigned To:	gitg-maint
QA Contact:	gitg-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2016-08-14 20:37 UTC by Rafał Jaskurzyński
Modified:	2016-08-15 11:48 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Crash during discarding unstaged changes on empty list (1.07 KB, patch) 2016-08-14 20:46 UTC, Rafał Jaskurzyński	none	Details \| Review
Crash during discarding unstaged changes on empty list (1.07 KB, patch) 2016-08-14 20:55 UTC, Rafał Jaskurzyński	none	Details \| Review
Crash during discarding unstaged changes on empty list (969 bytes, patch) 2016-08-14 21:00 UTC, Rafał Jaskurzyński	none	Details \| Review

Description Rafał Jaskurzyński 2016-08-14 20:37:18 UTC

Program crashed when clicking "discard changes" in "unstaged" section when there are no files on list

[Reproduce steps]
1. Go to staging area section
2. Right click on Unstaged section
3. Click discard changes
4. When list is empty crash occurs


[Core dump]

[Current thread is 1 (Thread 0x7f49fcaa8a40 (LWP 11498))]
(gdb) bt

+ Trace 236539

#0 _vala_g_strjoinv
at /home/rafal/jhbuild/install/share/vala-0.34/vapi/glib-2.0.vapi line 1057
#1 gitg_commit_activity_on_discard_menu_activated
at /home/rafal/checkout/gnome/gitg/gitg/commit/gitg-commit.vala line 1480
#2 g_closure_invoke
at /home/rafal/checkout/gnome/glib/gobject/gclosure.c line 804
#3 signal_emit_unlocked_R
at /home/rafal/checkout/gnome/glib/gobject/gsignal.c line 3629
#4 g_signal_emit_valist
at /home/rafal/checkout/gnome/glib/gobject/gsignal.c line 3385
#5 g_signal_emit
at /home/rafal/checkout/gnome/glib/gobject/gsignal.c line 3441
#6 gtk_widget_activate
at /home/rafal/checkout/gnome/gtk+/gtk/gtkwidget.c line 7749
#7 gtk_menu_shell_activate_item
at /home/rafal/checkout/gnome/gtk+/gtk/gtkmenushell.c line 1372
#8 gtk_menu_shell_button_release
at /home/rafal/checkout/gnome/gtk+/gtk/gtkmenushell.c line 791
#9 _gtk_marshal_BOOLEAN__BOXEDv
at gtkmarshalers.c line 131
#10 _g_closure_invoke_va
at /home/rafal/checkout/gnome/glib/gobject/gclosure.c line 867
#11 g_signal_emit_valist
at /home/rafal/checkout/gnome/glib/gobject/gsignal.c line 3294
#12 g_signal_emit
at /home/rafal/checkout/gnome/glib/gobject/gsignal.c line 3441
#13 gtk_widget_event_internal
at /home/rafal/checkout/gnome/gtk+/gtk/gtkwidget.c line 7716
#14 propagate_event_up
at /home/rafal/checkout/gnome/gtk+/gtk/gtkmain.c line 2546
#15 propagate_event
at /home/rafal/checkout/gnome/gtk+/gtk/gtkmain.c line 2648
#16 gtk_main_do_event
at /home/rafal/checkout/gnome/gtk+/gtk/gtkmain.c line 1879
#17 _gdk_event_emit
at /home/rafal/checkout/gnome/gtk+/gdk/gdkevents.c line 73
#18 gdk_event_source_dispatch
at /home/rafal/checkout/gnome/gtk+/gdk/x11/gdkeventsource.c line 367
#19 g_main_dispatch
at /home/rafal/checkout/gnome/glib/glib/gmain.c line 3201
#20 g_main_context_dispatch
at /home/rafal/checkout/gnome/glib/glib/gmain.c line 3854
#21 g_main_context_iterate
at /home/rafal/checkout/gnome/glib/glib/gmain.c line 3927
#22 g_main_context_iteration
#23 g_application_run
at /home/rafal/checkout/gnome/glib/gio/gapplication.c line 2381
#24 gitg_main_main
at /home/rafal/checkout/gnome/gitg/gitg/gitg.vala line 42
#25 __libc_start_main
at ../csu/libc-start.c line 291
#26 _start

Comment 1 Rafał Jaskurzyński 2016-08-14 20:46:56 UTC

Created attachment 333295 [details] [review]
Crash during discarding unstaged changes on empty list

Program crashed when clicking "discard changes" in "unstaged" section
when there are no files on list

Fix cancels further action if unstaged changes list is empty

Comment 2 Rafał Jaskurzyński 2016-08-14 20:55:22 UTC

Created attachment 333297 [details] [review]
Crash during discarding unstaged changes on empty list

Program crashed when clicking "discard changes" in "unstaged" section
when there are no files on list

Fix cancels further action if unstaged changes list is empty

Comment 3 Ignacio Casal Quinteiro (nacho) 2016-08-14 20:57:49 UTC

Review of attachment 333297 [details] [review]:

The indentation seems wrong. Can u fix it?

Comment 4 Rafał Jaskurzyński 2016-08-14 21:00:23 UTC

Created attachment 333298 [details] [review]
Crash during discarding unstaged changes on empty list

Program crashed when clicking "discard changes" in "unstaged" section
when there are no files on list

Fix cancels further action if unstaged changes list is empty

Comment 5 Rafał Jaskurzyński 2016-08-14 21:01:50 UTC

(In reply to Ignacio Casal Quinteiro (nacho) from comment #3)
> Review of attachment 333297 [details] [review] [review]:
> 
> The indentation seems wrong. Can u fix it?

Done in newest patchset

Comment 6 jessevdk@gmail.com 2016-08-15 11:48:27 UTC

Seems I overlooked the patch, sorry about that :( In the mean time I pushed another fix for the same issue. Thanks for the patch though!!