GNOME Bugzilla – Bug 769880
retro-gobject: Refactor retro-environment* files
Last modified: 2016-08-27 20:31:49 UTC
Libretro environment calls are handled by inline functions in private .h, which is a bit dirty. Having these as static functions in a .c file would be cleaner as they would be private, in a singel file and the compiler would probably inline them anyway if they are static as they are meant to be used in only one place.
Created attachment 333267 [details] [review] retro-gobject: Move retro-environment-core.h into retro-environment.c This helps making the code cleaner.
Created attachment 333268 [details] [review] retro-gobject: Move retro-environment-video.h into retro-environment.c This helps making the code cleaner.
Created attachment 333269 [details] [review] retro-gobject: Move retro-environment-input.h into retro-environment.c This helps making the code cleaner.
Created attachment 333270 [details] [review] retro-gobject: Move retro-environment-variable.h into retro-environment.c This helps making the code cleaner.
Created attachment 333272 [details] [review] retro-gobject: Move retro-environment-core.h into retro-environment.c This helps making the code cleaner.
Created attachment 333273 [details] [review] retro-gobject: Move retro-environment-video.h into retro-environment.c This helps making the code cleaner.
Created attachment 333274 [details] [review] retro-gobject: Move retro-environment-input.h into retro-environment.c This helps making the code cleaner.
Created attachment 333275 [details] [review] retro-gobject: Move retro-environment-variable.h into retro-environment.c This helps making the code cleaner.
Created attachment 333276 [details] [review] retro-gobject: Move retro-environment-interfaces.[ch] into retro-environment.c This helps making the code cleaner.
Review of attachment 333272 [details] [review]: Sure.
Review of attachment 333273 [details] [review]: ++
Review of attachment 333274 [details] [review]: Sure.
Review of attachment 333275 [details] [review]: ++
Review of attachment 333276 [details] [review]: ++
Attachment 333272 [details] pushed as aa93463 - retro-gobject: Move retro-environment-core.h into retro-environment.c Attachment 333273 [details] pushed as f119bad - retro-gobject: Move retro-environment-video.h into retro-environment.c Attachment 333274 [details] pushed as 9a86bcb - retro-gobject: Move retro-environment-input.h into retro-environment.c Attachment 333275 [details] pushed as 6e0ad76 - retro-gobject: Move retro-environment-variable.h into retro-environment.c Attachment 333276 [details] pushed as 442a9b5 - retro-gobject: Move retro-environment-interfaces.[ch] into retro-environment.c