After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769863 - Don't override IM variables
Don't override IM variables
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
git master
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-13 21:24 UTC by Gunnar Hjalmarsson
Modified: 2016-08-18 18:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't override IM variables (849 bytes, patch)
2016-08-14 01:32 UTC, Gunnar Hjalmarsson 		accepted-commit_now Details | Review

Description Gunnar Hjalmarsson 2016-08-13 21:24:43 UTC 
To give a user the option to use some other input method framework but IBus, gnome-session should not override the QT_IM_MODULE and XMODIFIERS environment variables if they are already set. The desired approach has been implemented in gnome-settings-daemon:

https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=21a16d25d981f3ce34b764dbc8005dbf8edfbe97

It would be consistent to change gnome-session in a similar way.
Comment 1 Gunnar Hjalmarsson 2016-08-14 01:32:33 UTC 
Created attachment 333258 [details] [review]
Don't override IM variables
Comment 2 Ray Strode [halfline] 2016-08-15 14:00:39 UTC 
Review of attachment 333258 [details] [review]:

sure.
Comment 3 Jeremy Bicha 2016-08-18 18:52:51 UTC 
Done in gnome-session 3.21.90:

https://git.gnome.org/browse/gnome-session/commit/?id=7060744ab857d867d74d553db4878df126211d56