After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769829 - Use libsoup instead of gvfs to download the covers
Use libsoup instead of gvfs to download the covers
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-13 12:19 UTC by Mathieu Bridon
Modified: 2016-08-13 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use libsoup instead of gvfs to download the covers (1.99 KB, patch)
2016-08-13 12:19 UTC, Mathieu Bridon 		committed Details | Review
Use libsoup instead of gvfs to download the covers (1.99 KB, patch)
2016-08-13 13:12 UTC, Mathieu Bridon 		committed Details | Review
grilo: Use Soup.Status.OK rather than magic number (886 bytes, patch)
2016-08-13 13:12 UTC, Mathieu Bridon 		committed Details | Review

Description Mathieu Bridon 2016-08-13 12:19:15 UTC 
gvfs doesn't work very well in flatpak.
Comment 1 Mathieu Bridon 2016-08-13 12:19:19 UTC 
Created attachment 333212 [details] [review]
Use libsoup instead of gvfs to download the covers

gvfs doesn't work very well in flatpak.
Comment 2 Bastien Nocera 2016-08-13 12:26:04 UTC 
Review of attachment 333212 [details] [review]:

Looks good to me.
Comment 3 Mathieu Bridon 2016-08-13 13:12:17 UTC 
The following fixes have been pushed:
e82e08e Use libsoup instead of gvfs to download the covers
91cf619 grilo: Use Soup.Status.OK rather than magic number
Comment 4 Mathieu Bridon 2016-08-13 13:12:25 UTC 
Created attachment 333215 [details] [review]
Use libsoup instead of gvfs to download the covers

gvfs doesn't work very well in flatpak.
Comment 5 Mathieu Bridon 2016-08-13 13:12:30 UTC 
Created attachment 333216 [details] [review]
grilo: Use Soup.Status.OK rather than magic number