After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769745 - gtask: Add guards for public functions
gtask: Add guards for public functions
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-08-11 14:43 UTC by Pavel Grunt
Modified: 2016-11-22 18:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtask: Add guards for public functions (5.82 KB, patch)
2016-08-11 14:43 UTC, Pavel Grunt 		committed Details | Review

Description Pavel Grunt 2016-08-11 14:43:40 UTC 
Created attachment 333118 [details] [review]
gtask: Add guards for public functions

Inform the user about wrong usage by a critical instead of segv
Comment 1 Colin Walters 2016-11-22 18:23:11 UTC 
Review of attachment 333118 [details] [review]:

Generally I prefer to have rationales even for commits like this.  Something like:

"I was debugging a segfault that would have been more obvious with these preconditions"
etc.
Comment 2 Colin Walters 2016-11-22 18:24:16 UTC 
Attachment 333118 [details] pushed as c99fe67 - gtask: Add guards for public functions