After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769729 - retro-gobject: Allow to search modules from their .info
retro-gobject: Allow to search modules from their .info
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: retro-gtk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
Depends on:
Blocks: 769678
 
 
Reported: 2016-08-11 07:46 UTC by Adrien Plazas
Modified: 2016-08-11 08:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Add RETRO_PLUGIN_PATH (1.38 KB, patch)
2016-08-11 08:11 UTC, Adrien Plazas 		committed Details | Review
retro-gobject: Add ModuleQuery (3.97 KB, patch)
2016-08-11 08:11 UTC, Adrien Plazas 		committed Details | Review
retro-gobject: Deprecate old module lookup functions (1.78 KB, patch)
2016-08-11 08:11 UTC, Adrien Plazas 		committed Details | Review

Description Adrien Plazas 2016-08-11 07:46:46 UTC 
We should make retro-gobject ease up the work to look for a valid libretro module to use depending on its .info file.
Comment 1 Adrien Plazas 2016-08-11 08:11:24 UTC 
Created attachment 333090 [details] [review]
build: Add RETRO_PLUGIN_PATH

This will be used in the next commit to look for libretro modules in
more places.

https://bugzilla.gnome.org/show_bug.cgi?id=769678
Comment 2 Adrien Plazas 2016-08-11 08:11:32 UTC 
Created attachment 333091 [details] [review]
retro-gobject: Add ModuleQuery

Add the ModuleQuery namespace containing the lookup_module_for_info()
and lookup_module_for_basename() functions.

This allows to look for libretro modules in more places and to support
the ones distributed with a .info file.

https://bugzilla.gnome.org/show_bug.cgi?id=769678
Comment 3 Adrien Plazas 2016-08-11 08:11:40 UTC 
Created attachment 333092 [details] [review]
retro-gobject: Deprecate old module lookup functions

Deprecate Retro.get_plugins_dir(), Retro.search_module() and
Config.PROJECT_PLUGINS_DIR as they have been replaced in the previous
commits.

https://bugzilla.gnome.org/show_bug.cgi?id=769678
Comment 4 Adrien Plazas 2016-08-11 08:14:35 UTC 
Attachment 333090 [details] pushed as 8f0678f - build: Add RETRO_PLUGIN_PATH
Attachment 333091 [details] pushed as b3825c9 - retro-gobject: Add ModuleQuery
Attachment 333092 [details] pushed as f720102 - retro-gobject: Deprecate old module lookup functions