After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769676 - ui: Look for covers alongside the game files
ui: Look for covers alongside the game files
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-09 16:17 UTC by Adrien Plazas
Modified: 2016-08-12 10:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
utils: Add LocalCover (3.57 KB, patch)
2016-08-11 09:48 UTC, Adrien Plazas
none Details | Review
utils: Add CompositeCover (1.59 KB, patch)
2016-08-11 09:48 UTC, Adrien Plazas
none Details | Review
Use local covers (17.86 KB, patch)
2016-08-11 09:48 UTC, Adrien Plazas
none Details | Review
utils: Add Directory (1.82 KB, patch)
2016-08-12 09:43 UTC, Adrien Plazas
committed Details | Review
utils: Add LocalCover (3.64 KB, patch)
2016-08-12 09:43 UTC, Adrien Plazas
committed Details | Review
utils: Add CompositeCover (1.59 KB, patch)
2016-08-12 09:43 UTC, Adrien Plazas
committed Details | Review
Use local covers (17.86 KB, patch)
2016-08-12 09:43 UTC, Adrien Plazas
committed Details | Review

Description Adrien Plazas 2016-08-09 16:17:56 UTC
We should allow users to set custom covers for their games, for example if we have 'file:///path/to/mario-bros.nes' we could look for any image file of the similar to 'file:///path/to/mario-bros.*'.

We could also look for an image file named 'cover.*' or 'folder.*' as it's common for music albums.
Comment 1 Adrien Plazas 2016-08-11 09:48:38 UTC
Created attachment 333105 [details] [review]
utils: Add LocalCover

This will be used in the next commits to look for image files named
similarly to a game file or named as cover files typically are.
Comment 2 Adrien Plazas 2016-08-11 09:48:44 UTC
Created attachment 333106 [details] [review]
utils: Add CompositeCover

This will be used in the next commit to get covers from multiple
sources.
Comment 3 Adrien Plazas 2016-08-11 09:48:50 UTC
Created attachment 333107 [details] [review]
Use local covers

When relevant, use the local covers before any other one.
Comment 4 Adrien Plazas 2016-08-12 09:43:01 UTC
Created attachment 333161 [details] [review]
utils: Add Directory

This will be used in the next commit to loop through files in a
directory.
Comment 5 Adrien Plazas 2016-08-12 09:43:09 UTC
Created attachment 333162 [details] [review]
utils: Add LocalCover

This will be used in the next commits to look for image files named
similarly to a game file or named as cover files typically are.
Comment 6 Adrien Plazas 2016-08-12 09:43:24 UTC
Created attachment 333163 [details] [review]
utils: Add CompositeCover

This will be used in the next commit to get covers from multiple
sources.
Comment 7 Adrien Plazas 2016-08-12 09:43:31 UTC
Created attachment 333164 [details] [review]
Use local covers

When relevant, use the local covers before any other one.
Comment 8 Adrien Plazas 2016-08-12 10:29:53 UTC
Attachment 333161 [details] pushed as 71b30aa - utils: Add Directory
Attachment 333162 [details] pushed as 6b33079 - utils: Add LocalCover
Attachment 333163 [details] pushed as d128771 - utils: Add CompositeCover
Attachment 333164 [details] pushed as 86458fd - Use local covers