GNOME Bugzilla – Bug 769674
some GIO tests' arbitrary timeouts are too short
Last modified: 2017-10-11 12:34:57 UTC
On a heavily loaded and not particularly fast ARM autobuilder (multiple packages building in parallel), gio/tests/file and gio/tests/gdbus-proxy sometimes fail. See the individual patches for more details. Not building packages in parallel on this particular machine is not really an option: we're trying to balance throughput with latency, and this is the least-bad configuration.
Created attachment 333001 [details] [review] gio/tests/file: increase an arbitrary timeout On slow ARM machines doing parallel builds, there's no guarantee that we'll get through this in 5 seconds.
Created attachment 333002 [details] [review] gio/tests/gdbus-proxy: sleep longer when testing that we time out On slow ARM machines doing parallel builds, there's no guarantee that we'll get scheduled in a window between (100ms|250ms) and 500ms.
I also have experienced similar situations too. Looks reasonable to fix it.
Review of attachment 333002 [details] [review]: Looks good to me, assuming you still need this for your builds?
Review of attachment 333001 [details] [review]: Looks good to me, assuming you still need this for your builds?
Comment on attachment 333001 [details] [review] gio/tests/file: increase an arbitrary timeout 7d5c738d
Comment on attachment 333002 [details] [review] gio/tests/gdbus-proxy: sleep longer when testing that we time out 331f73c2
Fixed in git for 2.55.0, thanks for reviewing!