Created attachment 332968 [details] [review]
chatView: Delegate state tracking to the app

In order to only mark messages as read when we can assume that the
user has seen it, we track both whether the view's toplevel window
has focus and whether the view's room is currently active. While
the existing code to do this isn't particularly bad, it is actually
simpler to delegate the state tracking to the application, with the
added benefit that it will be available to other modules that want
to apply the same check.

Created attachment 332969 [details] [review]
telepathyClient: Take over highlight notifications from ChatView

There is no need to tie notifications to a particular UI element, and
should we in fact ever support multiple windows or none, we'd run into
issues that are easily avoided by separating notifications from widgets.

The telepathy client looks like a reasonable place for monitoring
channels for highlights.

Created attachment 333058 [details] [review]
telepathyClient: Take over highlight notifications from ChatView

Updated help method to use a more unique name.

Review of attachment 332968 [details] [review]:

looks good to me.

Review of attachment 333058 [details] [review]:

looks good to me.

Attachment 332968 [details] pushed as 6453c59 - chatView: Delegate state tracking to the app
Attachment 333058 [details] pushed as 84c7a88 - telepathyClient: Take over highlight notifications from ChatView