After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769628 - sdpmessage: add support for rtcp-fb attributes
sdpmessage: add support for rtcp-fb attributes
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.8.1
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-08 13:37 UTC by Tomasz Zajac
Modified: 2018-11-03 11:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add parsing of rtcp-fb attributes (2.30 KB, patch)
2016-08-08 13:37 UTC, Tomasz Zajac 		none Details | Review

Description Tomasz Zajac 2016-08-08 13:37:16 UTC 
Created attachment 332940 [details] [review]
Add parsing of rtcp-fb attributes

There is no implementation for parsing rtcp-fb media attributes (like rtcp-fb-nack-pli or rtcp-fb-ccm-fir). If SDP contain such attribute, SDP parser should add relevant capability into RTP CAPS.
For example: 
If SDP contains "a=rtcp-fb:96 nack pli", relevant rtp caps should contain rtcp-fb-nack-pli=true. As it is now, it ends up as "a-rtcp-fb=(string)"96\ nack\ pli".

Please see enclosed patch which implements the missing feature.
Comment 1 Tomasz Zajac 2016-08-10 08:22:34 UTC 
Also see related patch for RTSP server:
https://bugzilla.gnome.org/show_bug.cgi?id=769698
Comment 2 GStreamer system administrator 2018-11-03 11:48:39 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/282.