After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769595 - Please backport mapbox provider fix to 3.10
Please backport mapbox provider fix to 3.10
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-08-07 02:06 UTC by Jeremy Bicha
Modified: 2016-08-08 15:42 UTC
See Also:
GNOME target: ---
GNOME version: 3.9/3.10


Attachments
Use margin_right instead of margin_end for Mapbox logo (888 bytes, patch)
2016-08-08 01:59 UTC, Jeremy Bicha
none Details | Review

Description Jeremy Bicha 2016-08-07 02:06:22 UTC
Ubuntu 14.04 LTS "universe" packages (like gnome-maps) are supported until April 2017 although packages in "main" like the default Unity desktop are supported until 2019. Ubuntu 14.04 LTS includes gnome-maps 3.10.2.

I tried applying the 3.14 mapbox patches to 3.10 but they don't apply cleanly.

Thanks!
Comment 1 Jonas Danielsson 2016-08-07 07:52:59 UTC
Hi! I will give it a go when I get sone time to spare! If someone else wanna try please go ahead! Look at gnome-3-14 branch and try to emulate.

3.12 wants this as well.

Thanks for filing!
Comment 3 Jeremy Bicha 2016-08-08 01:59:27 UTC
Created attachment 332902 [details] [review]
Use margin_right instead of margin_end for Mapbox logo

margin_end was added in GTK 3.12

https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-set-margin-right

Otherwise, gnome-maps errors on startup:

$ gnome-maps

(gnome-maps:1812): Gjs-WARNING **: JS ERROR: Error: No property margin_end on this GObject Gjs_AttributionLogo
_parent@resource:///org/gnome/gjs/modules/lang.js:131
AttributionLogo<._init@/usr/share/gnome-maps/js/mapSource.js:52
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
MainWindow<._init@/usr/share/gnome-maps/js/mainWindow.js:83
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
_Base.prototype._construct@resource:///org/gnome/gjs/modules/lang.js:110
Class.prototype._construct/newClass@resource:///org/gnome/gjs/modules/lang.js:204
Application<._createWindow@/usr/share/gnome-maps/js/application.js:97
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
Application<.vfunc_activate@/usr/share/gnome-maps/js/application.js:102
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
start@/usr/share/gnome-maps/js/main.js:28
@<command line>:1
Comment 4 Jonas Danielsson 2016-08-08 15:42:09 UTC
Thanks!

3.10.3.1 released with the patch:
https://download.gnome.org/sources/gnome-maps/3.10/