After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769538 - Use *.metainfo.xml as extension for the nautilus add-on
Use *.metainfo.xml as extension for the nautilus add-on
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-05 08:31 UTC by Debarshi Ray
Modified: 2016-08-06 11:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
appdata: Use *.metainfo.xml as extension for the nautilus add-on (5.54 KB, patch)
2016-08-05 08:49 UTC, Debarshi Ray 		none Details | Review
appdata: Use *.metainfo.xml as extension for the nautilus add-on (1.94 KB, patch)
2016-08-06 10:56 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2016-08-05 08:31:53 UTC 
Pedantically speaking, org.gnome.Terminal.Nautilus.appdata.xml.in should be renamed to org.gnome.Terminal.Nautilus.metainfo.xml.in to conform to the AppStream specification [1]. However, this is not a pressing problem because *.appdata.xml files are going to be supported for add-ons for the near future.

[1] https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Addon.html
Comment 1 Debarshi Ray 2016-08-05 08:49:11 UTC 
Created attachment 332783 [details] [review]
appdata: Use *.metainfo.xml as extension for the nautilus add-on
Comment 2 Christian Persch 2016-08-05 14:34:25 UTC 
Comment on attachment 332783 [details] [review]
appdata: Use *.metainfo.xml as extension for the nautilus add-on

 delete mode 100644 org.gnome.Terminal.Nautilus.appdata.xml.in
 create mode 100644 org.gnome.Terminal.Nautilus.metainfo.xml.in

This should be a git mv, not rm+add. With that fixed, ok to commit. Thanks!
Comment 3 Debarshi Ray 2016-08-06 10:55:21 UTC 
(In reply to Christian Persch from comment #2)
> Comment on attachment 332783 [details] [review] [review]
> appdata: Use *.metainfo.xml as extension for the nautilus add-on
> 
>  delete mode 100644 org.gnome.Terminal.Nautilus.appdata.xml.in
>  create mode 100644 org.gnome.Terminal.Nautilus.metainfo.xml.in
> 
> This should be a git mv, not rm+add. With that fixed, ok to commit. Thanks!

I did do a 'git mv' to rename the file. I think it is a matter of using -M with git format-patch when creating the attachment. I will reattach it with -M shortly.
Comment 4 Debarshi Ray 2016-08-06 10:56:24 UTC 
Created attachment 332818 [details] [review]
appdata: Use *.metainfo.xml as extension for the nautilus add-on
Comment 5 Christian Persch 2016-08-06 11:19:43 UTC 
Comment on attachment 332818 [details] [review]
appdata: Use *.metainfo.xml as extension for the nautilus add-on

Ok.
Comment 6 Debarshi Ray 2016-08-06 11:23:41 UTC 
Comment on attachment 332818 [details] [review]
appdata: Use *.metainfo.xml as extension for the nautilus add-on

Pushed to master.