After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769495 - game-boy: Support Game Boy Color
game-boy: Support Game Boy Color
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks: 769458
 
 
Reported: 2016-08-03 22:33 UTC by Adrien Plazas
Modified: 2016-08-27 20:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
game-boy: Add is_classic() to GameBoyHeader (1.10 KB, patch)
2016-08-27 20:24 UTC, Adrien Plazas 		committed Details | Review
game-boy: Add is_color() to GameBoyHeader (1.02 KB, patch)
2016-08-27 20:24 UTC, Adrien Plazas 		committed Details | Review
game-boy: Support Game Boy Color games (3.35 KB, patch)
2016-08-27 20:24 UTC, Adrien Plazas 		committed Details | Review

Description Adrien Plazas 2016-08-03 22:33:33 UTC 
Game Boy Color MIME type has recently been disambiguated from Game Boy, hence we need to explicitly support it.
Comment 1 Adrien Plazas 2016-08-27 20:24:25 UTC 
Created attachment 334284 [details] [review]
game-boy: Add is_classic() to GameBoyHeader

This will be used in the next commits to discriminte GameBoy headers
from GameBoyColor ones.
Comment 2 Adrien Plazas 2016-08-27 20:24:29 UTC 
Created attachment 334285 [details] [review]
game-boy: Add is_color() to GameBoyHeader

This will be used in the next commit to discriminte GameBoy headers from
GameBoyColor ones.
Comment 3 Adrien Plazas 2016-08-27 20:24:34 UTC 
Created attachment 334286 [details] [review]
game-boy: Support Game Boy Color games

The Game Boy Color MIME type have been discriminated from the Game Boy
one, hence we need to explicitly look for Game Boy Color games.
Comment 4 Adrien Plazas 2016-08-27 20:26:29 UTC 
Attachment 334284 [details] pushed as e662b10 - game-boy: Add is_classic() to GameBoyHeader
Attachment 334285 [details] pushed as de8201b - game-boy: Add is_color() to GameBoyHeader
Attachment 334286 [details] pushed as ed87cc1 - game-boy: Support Game Boy Color games