GNOME Bugzilla – Bug 769491
Can't print routes on 3.20.2
Last modified: 2016-08-06 14:57:16 UTC
With the recently released 3.20.2 I can't print out route instructions anymore. Not sure if this worked on 3.20.1. I get this in the terminal: (gnome-maps:15027): libchamplain-CRITICAL **: champlain_map_source_get_tile_size: assertion 'CHAMPLAIN_IS_MAP_SOURCE (map_source)' failed (gnome-maps:15027): libchamplain-CRITICAL **: champlain_map_source_chain_push: assertion 'CHAMPLAIN_IS_TILE_SOURCE (map_source)' failed (gnome-maps:15027): Gjs-CRITICAL **: JSObject* gjs_cairo_surface_from_surface(JSContext*, cairo_surface_t*): assertion 'surface != NULL' failed
https://git.gnome.org/browse/gnome-maps/tree/src/printLayout.js#n152 It uses champlain factory. Shouls switch to new MapSource.createStreetSource
Created attachment 332691 [details] [review] Print: Use new MapSource class Use the new MapSource class to create the map source for printing. This should be backported to 3.20 as well.
I think I fixed it with the above patch. Can't test though since it errors out in JHBuild for me because of missing icons. Please test as part of review!
(In reply to Mattias Bengtsson from comment #3) > I think I fixed it with the above patch. Can't test though since it errors > out in JHBuild for me because of missing icons. > > Please test as part of review! Hey I tested this patch. Though it is not throwing the errors. But it is taking to the dialog 'Loading map tiles for printing' and then nothing happens.
(In reply to amisha from comment #4) > (In reply to Mattias Bengtsson from comment #3) > > I think I fixed it with the above patch. Can't test though since it errors > > out in JHBuild for me because of missing icons. > > > > Please test as part of review! > > Hey I tested this patch. Though it is not throwing the errors. But it is > taking to the dialog 'Loading map tiles for printing' and then nothing > happens. Yeah, it does work. But I think the reason it fails is because it is too slow. Same could probably happen to someone with a slow connection with old mapSource. If you try the same route a couple of times to let the cache work. It will show you the route.
Attachment 332691 [details] pushed as 683fdf1 - Print: Use new MapSource class