After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769474 - mega-drive: Support Mega-CD
mega-drive: Support Mega-CD
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks: 769458
 
 
Reported: 2016-08-03 14:47 UTC by Adrien Plazas
Modified: 2016-08-17 20:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tracker: Check that files exist in MimeTypeTrackerQuery (1.14 KB, patch)
2016-08-17 20:18 UTC, Adrien Plazas
committed Details | Review
utils: Add CueSheetTrackMode.is_mode1() (993 bytes, patch)
2016-08-17 20:18 UTC, Adrien Plazas
committed Details | Review
saturn: Use CueSheetTrackMode.is_mode1() (1.35 KB, patch)
2016-08-17 20:18 UTC, Adrien Plazas
committed Details | Review
utils: Add FingerprintUid.for_chunk() (2.49 KB, patch)
2016-08-17 20:19 UTC, Adrien Plazas
committed Details | Review
mega-drive: Support Mega-CD games (5.11 KB, patch)
2016-08-17 20:19 UTC, Adrien Plazas
committed Details | Review

Description Adrien Plazas 2016-08-03 14:47:31 UTC
Mega-CD and Mega-CD 32X MIME type has recently been added and disambiguated from Mega Drive. We should support it.
Comment 1 Adrien Plazas 2016-08-17 20:18:45 UTC
Created attachment 333523 [details] [review]
tracker: Check that files exist in MimeTypeTrackerQuery

Make MimeTypeTrackerQuery.is_uri_valid() check that the file exist
rather than checking that the file's MIME type is correct.

This allows to make appear some games that should.
Comment 2 Adrien Plazas 2016-08-17 20:18:51 UTC
Created attachment 333524 [details] [review]
utils: Add CueSheetTrackMode.is_mode1()

This will be used in the next commits to make checking the track modes
of discs simpler.
Comment 3 Adrien Plazas 2016-08-17 20:18:56 UTC
Created attachment 333525 [details] [review]
saturn: Use CueSheetTrackMode.is_mode1()

Consider both MODE1 track modes as valid while making the code simpler
by using CueSheetTrackMode.is_mode1().
Comment 4 Adrien Plazas 2016-08-17 20:19:02 UTC
Created attachment 333526 [details] [review]
utils: Add FingerprintUid.for_chunk()

This will be used in the next commit to create an UID by hashing only
the header of a Mega-CD disc.
Comment 5 Adrien Plazas 2016-08-17 20:19:08 UTC
Created attachment 333527 [details] [review]
mega-drive: Support Mega-CD games
Comment 6 Adrien Plazas 2016-08-17 20:21:07 UTC
Attachment 333523 [details] pushed as 135c6bb - tracker: Check that files exist in MimeTypeTrackerQuery
Attachment 333524 [details] pushed as 227b612 - utils: Add CueSheetTrackMode.is_mode1()
Attachment 333525 [details] pushed as cb7d95c - saturn: Use CueSheetTrackMode.is_mode1()
Attachment 333526 [details] pushed as 59fc041 - utils: Add FingerprintUid.for_chunk()
Attachment 333527 [details] pushed as 3244b7c - mega-drive: Support Mega-CD games