After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769473 - mega-drive: Support Mega Drive 32X
mega-drive: Support Mega Drive 32X
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
: 769361 (view as bug list)
Depends on:
Blocks: 769458
 
 
Reported: 2016-08-03 14:45 UTC by Adrien Plazas
Modified: 2016-08-03 22:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mega-drive: Support 32x games (2.68 KB, patch)
2016-08-03 18:27 UTC, Adrien Plazas 		committed Details | Review
mega-drive: Add is_32x() to MegaDriveHeader (962 bytes, patch)
2016-08-03 18:27 UTC, Adrien Plazas 		committed Details | Review
mega-drive: Add is_mega_drive() to MegaDriveHeader (995 bytes, patch)
2016-08-03 18:27 UTC, Adrien Plazas 		committed Details | Review
mega-drive: Add 'system' prop to MegaDriveHeader (3.32 KB, patch)
2016-08-03 18:27 UTC, Adrien Plazas 		committed Details | Review
mega-drive: Update invalid header error message (1.05 KB, patch)
2016-08-03 18:27 UTC, Adrien Plazas 		committed Details | Review
mega-drive: Add MegaDriveSystem (1.34 KB, patch)
2016-08-03 18:28 UTC, Adrien Plazas 		committed Details | Review

Description Adrien Plazas 2016-08-03 14:45:28 UTC 
Mega Drive 32X MIME type has recently been disambiguated from Mega Drive, hence we need to explicitly support it.
Comment 1 Adrien Plazas 2016-08-03 18:26:47 UTC 
The following fixes have been pushed:
8b3027f mega-drive: Support 32x games
b692a07 mega-drive: Add is_32x() to MegaDriveHeader
1c67ece mega-drive: Add is_mega_drive() to MegaDriveHeader
c296b7a mega-drive: Add 'system' prop to MegaDriveHeader
58c9d79 mega-drive: Update invalid header error message
8f4d9f5 mega-drive: Add MegaDriveSystem
Comment 2 Adrien Plazas 2016-08-03 18:27:03 UTC 
Created attachment 332650 [details] [review]
mega-drive: Support 32x games

The 32X MIME type have been discriminated from the Mega Drive one, hence
we need to explicitly look for 32X games.
Comment 3 Adrien Plazas 2016-08-03 18:27:16 UTC 
Created attachment 332651 [details] [review]
mega-drive: Add is_32x() to MegaDriveHeader

This will be used in the next commit to discriminte Mega Drive headers
from 32X ones.
Comment 4 Adrien Plazas 2016-08-03 18:27:27 UTC 
Created attachment 332652 [details] [review]
mega-drive: Add is_mega_drive() to MegaDriveHeader

This will be used in the next commit to discriminte Mega Drive headers
from 32X ones.
Comment 5 Adrien Plazas 2016-08-03 18:27:36 UTC 
Created attachment 332653 [details] [review]
mega-drive: Add 'system' prop to MegaDriveHeader

This will be used in the next commit to discriminate the different
systems of the Mega Drive family.
Comment 6 Adrien Plazas 2016-08-03 18:27:53 UTC 
Created attachment 332654 [details] [review]
mega-drive: Update invalid header error message

Make the error message take into account all the possible systems.
Comment 7 Adrien Plazas 2016-08-03 18:28:07 UTC 
Created attachment 332655 [details] [review]
mega-drive: Add MegaDriveSystem

This will be used in the next commits to discriminate the different
systems of the Mega Drive family.
Comment 8 Adrien Plazas 2016-08-03 22:40:06 UTC 
*** Bug 769361 has been marked as a duplicate of this bug. ***