After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769446 - c-e: Hide firewall zone combo when firewalld is not running
c-e: Hide firewall zone combo when firewalld is not running
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-connection-editor
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
: 772540 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-08-02 17:22 UTC by Michael Catanzaro
Modified: 2016-10-07 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
c-e: Hide firewall zone combo when firewalld is not running (4.64 KB, patch)
2016-08-02 17:22 UTC, Michael Catanzaro 		none Details | Review

Description Michael Catanzaro 2016-08-02 17:22:56 UTC 
This is a follow-up to control center bug #763477.
Comment 1 Michael Catanzaro 2016-08-02 17:22:59 UTC 
Created attachment 332589 [details] [review]
c-e: Hide firewall zone combo when firewalld is not running

Currently, if firewalld is not running, then the firewall zone combo is
always insensitive. This would make sense if firewalld was great and we
were to consider it a distro bug to not have firewalld running and
enabled, then users would be able to see the option is disabled and
think "maybe my distro has done something wrong."

But in actuality, firewalld is not really great, only Fedora ships it
and we're not really recommending it to other distros. So hide the combo
if it's not running, else it's just broken on $NOTFEDORA.
Comment 2 Thomas Haller 2016-08-18 14:33:16 UTC 
lgtm
Comment 4 Thomas Haller 2016-10-07 12:12:36 UTC 
*** Bug 772540 has been marked as a duplicate of this bug. ***