After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769426 - Layout issues with privacy dialogs
Layout issues with privacy dialogs
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Privacy
git master
Other Linux
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-02 13:32 UTC by Allan Day
Modified: 2016-08-23 16:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.15 KB, patch)
2016-08-02 13:33 UTC, Allan Day 		none Details | Review
patch (1.76 KB, patch)
2016-08-02 13:33 UTC, Allan Day 		committed Details | Review
patch (6.49 KB, patch)
2016-08-02 13:34 UTC, Allan Day 		committed Details | Review
privacy: Align location services label with switch (2.07 KB, patch)
2016-08-23 16:17 UTC, Rui Matos 		committed Details | Review

Description Allan Day 2016-08-02 13:32:49 UTC 
They don't have enough spacing and they use the dim label style inconsistently.
Comment 1 Allan Day 2016-08-02 13:33:26 UTC 
Created attachment 332556 [details] [review]
patch
Comment 2 Allan Day 2016-08-02 13:33:55 UTC 
Created attachment 332558 [details] [review]
patch
Comment 3 Allan Day 2016-08-02 13:34:21 UTC 
Created attachment 332559 [details] [review]
patch
Comment 4 Rui Matos 2016-08-12 15:14:26 UTC 
Review of attachment 332556 [details] [review]:

Thanks for the patch Allan!

the problem here is that the GtkSwitch is packed in the GtkGrid spanning two lines (height=2) so that's what we should be changing here and then completely remove both the label and the switch valign props
Comment 5 Rui Matos 2016-08-12 15:18:05 UTC 
Review of attachment 332558 [details] [review]:

ok
Comment 6 Rui Matos 2016-08-12 15:21:07 UTC 
Review of attachment 332559 [details] [review]:

looks much better, thanks
Comment 7 Allan Day 2016-08-23 15:10:39 UTC 
(In reply to Rui Matos from comment #4)
> Review of attachment 332556 [details] [review] [review]:
> 
> Thanks for the patch Allan!
> 
> the problem here is that the GtkSwitch is packed in the GtkGrid spanning two
> lines (height=2) so that's what we should be changing here and then
> completely remove both the label and the switch valign props

That's beyond my meagre coding skills - if someone wants to take it on that would be great.
Comment 8 Rui Matos 2016-08-23 16:17:33 UTC 
Created attachment 334022 [details] [review]
privacy: Align location services label with switch

The GtkSwitch was using 2 grid rows for no reason which made the label
not align with it vertically.
Comment 9 Rui Matos 2016-08-23 16:18:17 UTC 
Attachment 334022 [details] pushed as 563155b - privacy: Align location services label with switch
Comment 10 Allan Day 2016-08-23 16:29:09 UTC 
Thanks Rui!