After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769372 - Tries to use discontinued MapQuest tiles to show contact maps [fixed in libchamplain 0.12.14]
Tries to use discontinued MapQuest tiles to show contact maps [fixed in libch...
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
: 768443 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-08-01 07:39 UTC by Marcus Lundblad
Modified: 2017-07-29 14:21 UTC
See Also:
GNOME target: 3.20
GNOME version: ---


Attachments
contacts-address-map: Use default map source (OSM MAPNIK) (943 bytes, patch)
2016-08-01 21:08 UTC, Jonas Danielsson
none Details | Review

Description Marcus Lundblad 2016-08-01 07:39:02 UTC
As in Maps, we need to update Contacts to use a new map tile source.
Comment 1 Marcus Lundblad 2016-08-01 07:39:51 UTC
Related gnome-maps bug:
https://bugzilla.gnome.org/show_bug.cgi?id=764841
Comment 2 Jonas Danielsson 2016-08-01 21:08:52 UTC
Created attachment 332493 [details] [review]
contacts-address-map: Use default map source (OSM MAPNIK)

MapQuest is no longer available for free, switch to OpenStreetMap
own tile server instead.

http://wiki.openstreetmap.org/wiki/Tile_usage_policy
Comment 3 Hussam Al-Tayeb 2016-08-01 22:13:39 UTC
*** Bug 768443 has been marked as a duplicate of this bug. ***
Comment 4 Michael Catanzaro 2016-08-02 15:16:18 UTC
Their tile usage policy very clearly prohibits distributing an application that uses tiles from openstreetmap.org without prior permission from their system administrators. Did we get such permission?

We also need to clearly display license attribution somehow, which is gonna clutter the UI. Seems easier to just remove the feature....
Comment 5 Michael Catanzaro 2016-08-02 15:17:03 UTC
Also regarding "Valid User-Agent identifying application. Faking another app's User-Agent WILL get you blocked." What user agent is used?
Comment 6 Jonas Danielsson 2016-08-02 15:32:04 UTC
(In reply to Michael Catanzaro from comment #4)
> Their tile usage policy very clearly prohibits distributing an application
> that uses tiles from openstreetmap.org without prior permission from their
> system administrators. Did we get such permission?
> 
> We also need to clearly display license attribution somehow, which is gonna
> clutter the UI. Seems easier to just remove the feature....

Bummer, no we have not received a permission. We clearly display license attribution, it is overlayed the map, that feature is part of libchamplain.

We could also just use the same tactic as with GNOME Maps and use the our Mapbox account here. But removing the feature seems fine as well. Who can make that call? Is it Eric?
Comment 7 Michael Catanzaro 2016-08-02 16:02:04 UTC
(In reply to Jonas Danielsson from comment #6)
> Bummer, no we have not received a permission. We clearly display license
> attribution, it is overlayed the map, that feature is part of libchamplain.

I suspect Contacts would not be considered a heavy user, we just need permission.

> We could also just use the same tactic as with GNOME Maps and use the our
> Mapbox account here.

That's preferable to removing features.
Comment 8 Stephen 2016-08-02 18:34:25 UTC
What's the argument against doing exactly the same as Maps (Mapbox via a proxy)? As a user, I don't want to see the feature removed when it seems there's already a good alternative.
Comment 9 fred 2016-08-17 16:10:59 UTC
I can confirm the issue. Gnome Maps works fine now. Why not patch gnome-contacts as well?
Comment 10 Alberto Salvia Novella 2016-09-06 15:03:49 UTC
Also reported in (https://bugs.launchpad.net/gnome-contacts/+bug/1620661).
Comment 11 Christian Stadelmann 2016-09-12 19:34:50 UTC
This bug is fixed with the latest release of libchamplain in version 0.12.14. You probably need to get your distribution to fix this bug by updating libchamplain.

Update for Fedora 24: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4467846364
Comment 12 Christian Stadelmann 2016-09-12 19:35:25 UTC
(In reply to Christian Stadelmann from comment #11)
> Update for Fedora 24:
> https://bodhi.fedoraproject.org/updates/FEDORA-2016-4467846364

Sorry, that was Fedora 25.

Fedora 24: https://bodhi.fedoraproject.org/updates/FEDORA-2016-15266b0988
Comment 13 André Klapper 2017-07-29 14:21:20 UTC
(In reply to Christian Stadelmann from comment #11)
> This bug is fixed with the latest release of libchamplain in version
> 0.12.14.

Hence closing this ticket as resolved.