GNOME Bugzilla – Bug 769349
thegamesdb: Add PC games support
Last modified: 2016-08-25 13:08:57 UTC
We should support PC games. The 'application/x-desktop' MIME-type looks like a good candidate for that.
Created attachment 332436 [details] [review] thegamesdb: Add PC games support Add PC games support via the 'application/x-desktop' MIME type.
Review of attachment 332436 [details] [review]: I'd really rather not overload the application/x-desktop mime-type. application/x-pc-game ?
Yeah it makes sense to specify it's a game type, though PC may be a bit too specific, what about application/x-desktop-game? Maybe we could even register it as a subtype of application/x-desktop, looking for "Game;" or similar lines, but it's probably not a good idea.
(In reply to Adrien Plazas from comment #3) > Yeah it makes sense to specify it's a game type, though PC may be a bit too > specific, what about application/x-desktop-game? > > Maybe we could even register it as a subtype of application/x-desktop, > looking for "Game;" or similar lines, but it's probably not a good idea. But thegamesdb has a specific "PC" section, but it has a separate MacOS section too. So it's really not a "desktop" game. I'd rather we made that clear, especially as thegamesdb is to get games metadata. We really don't want it to be related to any "real" mime-type, one registered in shared-mime-info, as we never have a single file PC game.
OK, I'm convinced. :)
Created attachment 332586 [details] [review] thegamesdb: Add PC games support Add PC games support via the unregistered 'application/x-pc-game' MIME type.
Created attachment 332590 [details] [review] thegamesdb: Set 'PC' as the default platform This adds PC games support.
Review of attachment 332590 [details] [review]: LGTM
Is it possible to merge this and the other patches related to thegamesdb soonish so we can use them in Games 3.22?
Attachment 332590 [details] pushed as d646b44 - thegamesdb: Set 'PC' as the default platform