After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769347 - thegamesdb: Support PlayStation games
thegamesdb: Support PlayStation games
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks: 769348
 
 
Reported: 2016-07-31 10:26 UTC by Adrien Plazas
Modified: 2016-08-25 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
thegamesdb: Add PlayStation support (1.29 KB, patch)
2016-07-31 10:27 UTC, Adrien Plazas
committed Details | Review
thegamesdb: Add PlayStation support (1.31 KB, patch)
2016-08-02 14:04 UTC, Adrien Plazas
none Details | Review

Description Adrien Plazas 2016-07-31 10:26:01 UTC
We should support PlayStation games even though there is no registered MIME type for them.
Comment 1 Adrien Plazas 2016-07-31 10:27:46 UTC
Created attachment 332425 [details] [review]
thegamesdb: Add PlayStation support

Add PlayStation support via the unregistered
'application/x-playstation-rom' MIME type as none is registered for
PlayStation discs.
Comment 2 Bastien Nocera 2016-08-02 11:07:12 UTC
Review of attachment 332425 [details] [review]:

::: src/lua-factory/sources/grl-thegamesdb.lua
@@ +219,3 @@
     platform_names['application/x-pc-engine-rom'] = 'TurboGrafx 16'
+    -- 'application/x-playstation-rom' is an unregistered MIME type
+    platform_names['application/x-playstation-rom'] = 'Sony Playstation'

I prefer application/x-playstation-disc-image
Comment 3 Adrien Plazas 2016-08-02 13:45:10 UTC
Agreed, especially as it doesn't represent the binary tracks/files of the disc.
Comment 4 Adrien Plazas 2016-08-02 14:04:38 UTC
Created attachment 332561 [details] [review]
thegamesdb: Add PlayStation support

Add PlayStation support via the unregistered
'application/x-playstation-disc-image' MIME type as none is registered
for PlayStation discs.
Comment 5 Bastien Nocera 2016-08-02 14:54:39 UTC
(In reply to Adrien Plazas from comment #3)
> Agreed, especially as it doesn't represent the binary tracks/files of the
> disc.

I changed my mind, after browsing through shared-mime-info, as all the disc image formats for consoles use "-rom", such as the ones for the Wii, GameCube, Saturn, Sega-CD, etc.
Comment 6 Adrien Plazas 2016-08-25 13:22:36 UTC
Attachment 332425 [details] pushed as 38fa5ac - thegamesdb: Add PlayStation support