After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769339 - chatView: Fix outgoing check when acknowledging message
chatView: Fix outgoing check when acknowledging message
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-30 22:35 UTC by Florian Müllner
Modified: 2016-07-31 00:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
chatView: Fix outgoing check when acknowledging message (1.11 KB, patch)
2016-07-30 22:35 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2016-07-30 22:35:20 UTC 
See patch - fallout from commit cfe392ce6fd ...
Comment 1 Florian Müllner 2016-07-30 22:35:27 UTC 
Created attachment 332415 [details] [review]
chatView: Fix outgoing check when acknowledging message

All outgoing messages have a pending ID of 0, but it may also be a valid
ID for incoming ones. So instead of checking whether the ID itself is
"true-ish" (which isn't the case for 0), test explicitly for undefined.
Comment 2 Rares Visalom 2016-07-30 23:27:02 UTC 
Review of attachment 332415 [details] [review]:

Not much of a review here, it's only one line after all :) i did understand the reason as the commit message explained it all. looks good to me
Comment 3 Florian Müllner 2016-07-31 00:01:31 UTC 
Attachment 332415 [details] pushed as 1faedd1 - chatView: Fix outgoing check when acknowledging message