After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769329 - ui: Add fullscreen support
ui: Add fullscreen support
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-30 16:37 UTC by Adrien Plazas
Modified: 2016-07-31 07:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
command: Add 'can_fullscreen' prop to CommandRunner (862 bytes, patch)
2016-07-30 16:38 UTC, Adrien Plazas 		committed Details | Review
dummy: Add 'can_fullscreen' prop to DummyRunner (837 bytes, patch)
2016-07-30 16:38 UTC, Adrien Plazas 		committed Details | Review
retro: Add 'can_fullscreen' prop to RetroRunner (843 bytes, patch)
2016-07-30 16:38 UTC, Adrien Plazas 		committed Details | Review
core: Add 'can_fullscreen' prop to Runner (779 bytes, patch)
2016-07-30 16:38 UTC, Adrien Plazas 		committed Details | Review
ui: Add the fullscreen header bar to the DisplayBox (4.94 KB, patch)
2016-07-30 16:38 UTC, Adrien Plazas 		committed Details | Review
ui: Make ApplicationWindow handle fullscreen (3.76 KB, patch)
2016-07-30 16:39 UTC, Adrien Plazas 		committed Details | Review
ui: Add fullscreen buttons to the display header bar (6.77 KB, patch)
2016-07-30 16:39 UTC, Adrien Plazas 		committed Details | Review

Description Adrien Plazas 2016-07-30 16:37:39 UTC 
We should be able to play games in fullscreen.
Comment 1 Adrien Plazas 2016-07-30 16:38:21 UTC 
Created attachment 332396 [details] [review]
command: Add 'can_fullscreen' prop to CommandRunner

This will be used in a subsequent commit to support fullscreen.
Comment 2 Adrien Plazas 2016-07-30 16:38:30 UTC 
Created attachment 332397 [details] [review]
dummy: Add 'can_fullscreen' prop to DummyRunner

This will be used in a subsequent commit to support fullscreen.
Comment 3 Adrien Plazas 2016-07-30 16:38:42 UTC 
Created attachment 332398 [details] [review]
retro: Add 'can_fullscreen' prop to RetroRunner

This will be used in a subsequent commit to support fullscreen.
Comment 4 Adrien Plazas 2016-07-30 16:38:49 UTC 
Created attachment 332399 [details] [review]
core: Add 'can_fullscreen' prop to Runner

This will be used in a subsequent commit to support fullscreen.
Comment 5 Adrien Plazas 2016-07-30 16:38:57 UTC 
Created attachment 332400 [details] [review]
ui: Add the fullscreen header bar to the DisplayBox

This will be used in a subsequent commit to support fullscreen.
Comment 6 Adrien Plazas 2016-07-30 16:39:05 UTC 
Created attachment 332401 [details] [review]
ui: Make ApplicationWindow handle fullscreen

This will be used in the next commit to implement fullscreen support.
Comment 7 Adrien Plazas 2016-07-30 16:39:15 UTC 
Created attachment 332402 [details] [review]
ui: Add fullscreen buttons to the display header bar

This finishes implementing fullscreen support.
Comment 8 Adrien Plazas 2016-07-31 07:55:53 UTC 
Attachment 332396 [details] pushed as 652f8cb - command: Add 'can_fullscreen' prop to CommandRunner
Attachment 332398 [details] pushed as 3569f4b - retro: Add 'can_fullscreen' prop to RetroRunner
Attachment 332399 [details] pushed as 36f8de7 - core: Add 'can_fullscreen' prop to Runner
Attachment 332400 [details] pushed as 8676b9f - ui: Add the fullscreen header bar to the DisplayBox
Attachment 332401 [details] pushed as 4ccd77d - ui: Make ApplicationWindow handle fullscreen
Attachment 332402 [details] pushed as a17690c - ui: Add fullscreen buttons to the display header bar