After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769283 - pulseaudio lists audio/L16 (non-transcoded) source twice.
pulseaudio lists audio/L16 (non-transcoded) source twice.
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: general
0.30.x
Other Linux
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2016-07-28 17:23 UTC by Eric Toombs
Modified: 2016-08-13 15:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
engine-gst: Don't proxy HTTP URIs (1.62 KB, patch)
2016-08-13 15:16 UTC, Jens Georg
none Details | Review
V2 of the fix with some clean-up of string compare (3.25 KB, patch)
2016-08-13 15:28 UTC, Jens Georg
committed Details | Review

Description Eric Toombs 2016-07-28 17:23:11 UTC
org.gnome.UPnP.MediaServer2.PulseAudio generates one URL linking directly to pulseaudio's http server, and another linking to rygel's, which is then proxied to pulseaudio without transcoding.

pulseaudio direct link:
http://127.0.0.1:4714/listen/source/alsa_output.pci-0000_00_1b.0.analog-stereo.monitor

rygel proxied link:
http://192.168.2.29:40621/org.gnome.UPnP.MediaServer2.PulseAudio/i/L29yZy9nbm9tZS9VUG5QL01lZGlhU2VydmVyMi9QdWxzZUF1ZGlvL1NpbmtzLzA%3D/res/primary_http.monitor

For one thing, proxying is completely broken currently, due to bug #749775. For another thing, it publishes a direct link to localhost instead of the actual LAN IP address.

This extra link still appears even when transcoding is disabled.

I wasn't entirely sure whether it was a problem with pulseaudio or rygel, so this might need to get moved.
Comment 1 Eric Toombs 2016-07-28 17:25:35 UTC
Actually, I couldn't find any documentation on pulseaudio's MediaServer2 interface anywhere except for passing mentions on the Rygel wiki, so I assumed pulseaudio's mediaserver2 support was implemented by rygel. If there is any documentation, I'd love to read it.
Comment 2 Jens Georg 2016-07-28 20:24:29 UTC
No, Pulse people (Lennart even?) implemented it according to the Spec in Rygel wiki space.

The proxy might be added because the URI points to localhost, but not sure.
Comment 3 Jens Georg 2016-08-13 15:16:40 UTC
Created attachment 333228 [details] [review]
engine-gst: Don't proxy HTTP URIs

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 4 Jens Georg 2016-08-13 15:28:26 UTC
Created attachment 333236 [details] [review]
V2 of the fix with some clean-up of string compare