GNOME Bugzilla – Bug 769280
build: Check for runtime dependencies
Last modified: 2016-07-28 16:28:02 UTC
See patches.
Created attachment 332287 [details] [review] build: Replace custom check for gjs autoconf-archive now ships a AX_PROG_GJS macro we can use.
Created attachment 332288 [details] [review] build: Check for runtime dependencies So far we only include checks for dependencies needed at compile-time in configure, which is inconvenient for users who try to build polari themselves. autoconf-archive now ships an AX_CHECK_GIRS_GJS macro we can use to check for girs we depend on at runtime without cluttering compiler and linker flags, which was the main reason for not checking for runtime dependencies.
Review of attachment 332287 [details] [review]: looks sane to me
Review of attachment 332288 [details] [review]: just a question: ::: configure.ac @@ +47,3 @@ +AX_CHECK_GIRS_GJS([GLib], [2.0]) +AX_CHECK_GIRS_GJS([GObject], [2.0]) +AX_CHECK_GIR_SYMBOLS_GJS([Gtk], [3.0], [ScrolledWindow.set_max_content_height]) Gtk 3.0 is minimum requirement? or how should these numbers be understood?
(In reply to Bastian Ilsø from comment #4) > Gtk 3.0 is minimum requirement? or how should these numbers be understood? That's the API version of the GIR (read: "Gtk-3.0.gir"), not a minimum requirement of the library version: http://git.savannah.gnu.org/cgit/autoconf-archive.git/tree/m4/ax_check_gir_symbols_gjs.m4#n22 That's why there's a check for ScrolledWindow.set_max_content_height, which is the most recent API addition we require as far as I can tell.
Attachment 332287 [details] pushed as b7e4519 - build: Replace custom check for gjs Attachment 332288 [details] pushed as c6f5b12 - build: Check for runtime dependencies