GNOME Bugzilla – Bug 769230
Misc network fixes
Last modified: 2016-08-30 15:18:49 UTC
See also https://bugzilla.gnome.org/show_bug.cgi?id=705546
Created attachment 332217 [details] [review] network: Fix warning when enabling hotspot GLib-GObject-WARNING **: g_object_set_valist: object class 'NMSettingWireless' has no property named 'security'
Created attachment 332218 [details] [review] network: Fix saving of IPv6 gateway
Created attachment 332219 [details] [review] network: Fix warning if IPv6 gateway is empty GtkEntry doesn't like NULL text.
Created attachment 332220 [details] [review] network: Fix IPv6 settings not being applicable when method changes When changing the method from Manual to Automatic, we need to clear the gateway setting, otherwise the settings verification will fail: ipv6.gateway: gateway cannot be set if there are no addresses configured Another fallout of the libnm 1.2 port
Created attachment 332221 [details] [review] network: Remove unused ->validate class implementations The implementation of ->validate in the parent class will return TRUE if there's no implementation in the child class, so no need to implement those.
Created attachment 332222 [details] [review] network: Return better error when 8021x security is invalid Rather than the generic "Invalid 802.1x security".
Created attachment 332223 [details] [review] network: Avoid setting a GError if already set If the wireless security is invalid, don't try to set the GError if the ad-hoc mode is invalid as well.
Review of attachment 332217 [details] [review]: ok
Review of attachment 332218 [details] [review]: could also drop this variable since if text_gateway isn't valid we'll hit if (!ret) continue;
Review of attachment 332219 [details] [review]: sure
Review of attachment 332220 [details] [review]: could also be done unconditionally like we do nm_setting_ip_config_clear_addresses() to ensure a clean slate
Review of attachment 332221 [details] [review]: ++
Review of attachment 332222 [details] [review]: right
Review of attachment 332223 [details] [review]: yep
Attachment 332217 [details] pushed as cdb6a6c - network: Fix warning when enabling hotspot Attachment 332218 [details] pushed as dc14602 - network: Fix saving of IPv6 gateway Attachment 332219 [details] pushed as 94e2be8 - network: Fix warning if IPv6 gateway is empty Attachment 332220 [details] pushed as a90dc60 - network: Fix IPv6 settings not being applicable when method changes Attachment 332221 [details] pushed as 73a8d38 - network: Remove unused ->validate class implementations Attachment 332222 [details] pushed as b0329f8 - network: Return better error when 8021x security is invalid Attachment 332223 [details] pushed as 2a6706f - network: Avoid setting a GError if already set