Bug 769226 – Crash when disposing EphyURITester after didFailToSendSyncMessage

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 769226 - Crash when disposing EphyURITester after didFailToSendSyncMessage


Summary:	Crash when disposing EphyURITester after didFailToSendSyncMessage


Status:	RESOLVED OBSOLETE

Product:	epiphany
Classification:	Core
Component:	General
Version:	3.20.x (obsolete)
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Epiphany Maintainers
QA Contact:	Epiphany Maintainers

URL:
Whiteboard:

Depends on:	769227
Blocks:

Reported:	2016-07-27 14:03 UTC by Michael Catanzaro
Modified:	2018-08-03 20:50 UTC

See Also:	https://bugzilla.redhat.com/show_bug.cgi?id=1319898 https://bugzilla.redhat.com/show_bug.cgi?id=1336884 https://bugzilla.redhat.com/show_bug.cgi?id=1354110
GNOME target:	---
GNOME version:	---

Description Michael Catanzaro 2016-07-27 14:03:48 UTC

We have 303 reports of this crash in Fedora, where EphyURITester is disposed from the web extension in an exit handler after didFailToSendSyncMessage:

+ Trace 236485

Thread 1 (Thread 0x7fda63768ac0 (LWP 5612))

#0 malloc_consolidate
at malloc.c line 4168
#1 _int_free
at malloc.c line 4076
#2 __GI___libc_free
at malloc.c line 2969
#3 g_free
at gmem.c line 189
#4 g_hash_table_remove_all_nodes
at ghash.c line 554
#5 g_hash_table_remove_all_nodes
at ghash.c line 1426
#6 g_hash_table_remove_all
at ghash.c line 1429
#7 g_hash_table_destroy
at ghash.c line 1122
#8 ephy_uri_tester_finalize
at ephy-uri-tester.c line 925
#9 g_object_unref
at gobject.c line 3183
#10 ephy_web_extension_dispose
at ephy-web-extension.c line 1290
#11 g_object_unref
at gobject.c line 3146
#12 _dl_fini
at dl-fini.c line 235
#13 __run_exit_handlers
at exit.c line 82
#14 __GI_exit
at exit.c line 104
#15 IPC::Connection::didFailToSendSyncMessage
at /usr/src/debug/webkitgtk-2.11.91/Source/WebKit2/Platform/IPC/Connection.cpp line 873


Not sure what's wrong; our GHashTable usage LOOKS safe to me. Everything is harder in exit handlers. My instinct is to just stop freeing the web extension, but I hear Carlos in my head telling me we really should understand the bug before making such a choice.

See the downstream bug (or duplicates) for full backtrace.

Comment 1 Michael Catanzaro 2016-07-27 14:04:52 UTC

(Crashes are always critical on GNOME Bugzilla)

Comment 2 Michael Catanzaro 2016-08-01 16:57:38 UTC

Note this is maybe not a good bug to spend time on, because:

mcatanzaro:  aperez: also our current adblocker has some nasty crash we need to figure out: https://bugzilla.gnome.org/show_bug.cgi?id=769226. Will you be deleting all that code?
aperez:  mcatanzaro: yes!

Comment 3 Michael Catanzaro 2017-01-23 03:50:35 UTC

(In reply to Michael Catanzaro from comment #2)
> Note this is maybe not a good bug to spend time on, because:
> 
> mcatanzaro:  aperez: also our current adblocker has some nasty crash we need
> to figure out: https://bugzilla.gnome.org/show_bug.cgi?id=769226. Will you
> be deleting all that code?
> aperez:  mcatanzaro: yes!

I don't believe this will happen anytime soon.

Comment 4 GNOME Infrastructure Team 2018-08-03 20:50:18 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/epiphany/issues/319.