GNOME Bugzilla – Bug 769213
Let goa_provider_show_account have more control over the UI
Last modified: 2016-08-14 22:17:52 UTC
It is not ideal to have the UI split across a relatively fine-grained, semi-stable, cross-module interface boundary. Non-trivial changes to the UI require changes to the goa_provider_show_account interface. In fact, we are already not using it the way it was originally intended to be- the 2nd GtkGrid* parameter is just a dummy these days.
Moreover, it prevents us from having a sufficiently different UI for certain account types by enforcing the same high level layout for everything. For example, these mockups for Kerberos accounts won't fit into the current layout: https://dl.dropboxusercontent.com/u/5031519/settings/goa-kerberos.png
Therefore, let's just pass a high level container to goa_provider_show_account, which the GoaProvider can use whichever way it feels like.
Created attachment 332199 [details] [review]
[g-o-a] Rename goa_util_add_account_info as goa_utils_account_add_header
Created attachment 332200 [details] [review]
[g-o-a] utils: Add goa_utils_account_add_attention_needed
Created attachment 332201 [details] [review]
[g-o-a] Only accept a vertical GtkBox via goa_provider_show_account
Created attachment 332202 [details] [review]
[g-c-c] online-accounts: Let goa_provider_show_account create the full UI
(In reply to Debarshi Ray from comment #0)
> Therefore, let's just pass a high level container to
> goa_provider_show_account, which the GoaProvider can use whichever way it
> feels like.
Ideally, I'd completely get rid of the last two parameters. However, it might be wise to wait until we have revamped the entire panel so that we are really sure about what we are doing and avoid any unexpected API churn.
Committed to master after talking to Bastien at GUADEC.