After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769209 - [PATCH] Fix non-literal format string warnings
[PATCH] Fix non-literal format string warnings
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gitg
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2016-07-27 04:31 UTC by Ting-Wei Lan
Modified: 2016-08-14 08:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix non-literal format string warnings (1.53 KB, patch)
2016-07-27 04:32 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2016-07-27 04:31:02 UTC 
There are a few non-literal format string warnings showed when compiling gitg with clang:

gitg/commit/gitg-commit.vala:1315:28: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
        _tmp3_ = g_strdup_printf (_tmp2_);
                                  ^~~~~~
gitg/gitg-author-details-dialog.vala:231:141: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
        _tmp1_ = (GtkMessageDialog*) gtk_message_dialog_new ((GtkWindow*) self, GTK_DIALOG_DESTROY_WITH_PARENT, GTK_MESSAGE_ERROR, GTK_BUTTONS_OK, _tmp0_);
                                                                                                                                                   ^~~~~~
Comment 1 Ting-Wei Lan 2016-07-27 04:32:22 UTC 
Created attachment 332190 [details] [review]
Fix non-literal format string warnings
Comment 2 jessevdk@gmail.com 2016-08-14 08:32:34 UTC 
Attachment 332190 [details] pushed as 444c3f3 - Fix non-literal format string warnings