After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769194 - Adwaita: proof of concept of a red variant
Adwaita: proof of concept of a red variant
Product: gtk+
Classification: Platform
Component: Themes
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
Depends on:
Reported: 2016-07-26 15:09 UTC by Antonio Ospite
Modified: 2016-08-01 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Adwaita: add a red variant (199.77 KB, patch)
2016-07-26 15:09 UTC, Antonio Ospite
none Details | Review
Adwaita: add a red variant v2 (10.87 KB, patch)
2016-07-27 21:11 UTC, Antonio Ospite
none Details | Review

Description Antonio Ospite 2016-07-26 15:09:16 UTC
Created attachment 332144 [details] [review]
Adwaita: add a red variant


I noticed that the name of a theme variant can be arbitrary, it doesn't have to be necessarily "light" or "dark", so I tried adding a "red" variant and I experimented using it to change the windows style when the user operates as root.

I am attaching the patch; and here is a demo:

This is just a proof of concept, I wanted to share it here for reference but feel free to close the bug as WONTFIX, I'll understand :)

Comment 1 Lapo Calamandrei 2016-07-26 18:31:50 UTC
Having a full variant to indicate the application is running at root is way too much for a minor usecase (which shouldn't really exist in a perfect world also), think about the maintenance cost. It would be nice to visually hint that an application is running as root, but I'd do something at the window level problably (like a red shadow or something) which would tackle non gtk+3 apps too.
A full root-look variant is totally a WONTFIX to me, indicating apps running as root in a less expensive and generic way would be fine on the other hand, so shall I change the topic accordingly or close?
Comment 2 Antonio Ospite 2016-07-26 20:40:31 UTC
I guess you can close the report, it was just a quick and dirty experiment about having a variant with an arbitrary name.

About the example use case: I don't think I'll be looking anytime soon at a better mechanism to highlight apps running as root.

Comment 3 Antonio Ospite 2016-07-27 21:11:56 UTC
Created attachment 332240 [details] [review]
Adwaita: add a red variant v2

Even if this is not going to be merged, I think it is better to attach a smaller proof-of-concept patch in which the red variant imports the pre-processed light theme and restyles only the needed elements, instead of duplicating all the code.