GNOME Bugzilla – Bug 769194
Adwaita: proof of concept of a red variant
Last modified: 2016-08-01 12:55:40 UTC
Created attachment 332144 [details] [review] Adwaita: add a red variant Hi, I noticed that the name of a theme variant can be arbitrary, it doesn't have to be necessarily "light" or "dark", so I tried adding a "red" variant and I experimented using it to change the windows style when the user operates as root. I am attaching the patch; and here is a demo: https://youtu.be/nrU6tZtqrIw This is just a proof of concept, I wanted to share it here for reference but feel free to close the bug as WONTFIX, I'll understand :) Thanks, Antonio
Having a full variant to indicate the application is running at root is way too much for a minor usecase (which shouldn't really exist in a perfect world also), think about the maintenance cost. It would be nice to visually hint that an application is running as root, but I'd do something at the window level problably (like a red shadow or something) which would tackle non gtk+3 apps too. A full root-look variant is totally a WONTFIX to me, indicating apps running as root in a less expensive and generic way would be fine on the other hand, so shall I change the topic accordingly or close?
I guess you can close the report, it was just a quick and dirty experiment about having a variant with an arbitrary name. About the example use case: I don't think I'll be looking anytime soon at a better mechanism to highlight apps running as root. Thanks, Antonio
Created attachment 332240 [details] [review] Adwaita: add a red variant v2 Even if this is not going to be merged, I think it is better to attach a smaller proof-of-concept patch in which the red variant imports the pre-processed light theme and restyles only the needed elements, instead of duplicating all the code.