After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769142 - Adjust styles for GTK 3.20
Adjust styles for GTK 3.20
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-25 08:18 UTC by Alexander Mikhaylenko
Modified: 2016-09-22 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GNOME 3.20 and 3.18 calculators side by side (121.23 KB, image/png)
2016-07-25 08:18 UTC, Alexander Mikhaylenko 		  Details
Fix for GTK 3.20 (1.38 KB, patch)
2016-07-25 08:21 UTC, Alexander Mikhaylenko 		committed Details | Review
Left-to-right: 3.20.x, 3.18.x, 3.21.2 with the patch (129.29 KB, image/png)
2016-07-25 08:23 UTC, Alexander Mikhaylenko 		  Details

Description Alexander Mikhaylenko 2016-07-25 08:18:42 UTC 
Created attachment 332077 [details]
GNOME 3.20 and 3.18 calculators side by side

With GTK 3.20 there are some visual glitches with MathDisplay/HistoryView:
1. History view has double borders.
2. Math display scrolling window has too low min-content-height, so it shows scrollbars in a newly opened window.

See attached screenshot.
Comment 1 Alexander Mikhaylenko 2016-07-25 08:21:30 UTC 
Created attachment 332078 [details] [review]
Fix for GTK 3.20

The patch fixes that for GTK 3.20. However, it would probably break with 3.18, I'm not sure what to do here. :/
Comment 2 Alexander Mikhaylenko 2016-07-25 08:23:50 UTC 
Created attachment 332079 [details]
Left-to-right: 3.20.x, 3.18.x, 3.21.2 with the patch
Comment 3 Lapo Calamandrei 2016-09-22 12:40:07 UTC 
It would be better to axed the borders with border-style, so it won't override theme border width settings, so, something like: 'border-style: none none solid none;' would be better.
Comment 4 Carlos Soriano 2016-09-22 12:52:30 UTC 
Lapo asked for it and it's a pretty obvious fix. Pushed.
Comment 5 Carlos Soriano 2016-09-22 12:55:28 UTC 
Also thanks for the patch :)

The pushed commit is:
https://git.gnome.org/browse/gnome-calculator/commit/?id=bad0f883d6c086d90ca2e07991dbe2d76de9aa24