After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769134 - application: clear icon info caches on shutdown
application: clear icon info caches on shutdown
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-24 20:12 UTC by Ernestas Kulik
Modified: 2016-07-25 12:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
application: clear icon caches on shutdown (1.86 KB, patch)
2016-07-24 20:12 UTC, Ernestas Kulik 		none Details | Review
application: clear icon caches on shutdown (1.87 KB, patch)
2016-07-24 20:15 UTC, Ernestas Kulik 		committed Details | Review

Description Ernestas Kulik 2016-07-24 20:12:14 UTC 
Tracked down another leak. See patch.
Comment 1 Ernestas Kulik 2016-07-24 20:12:18 UTC 
Created attachment 332052 [details] [review]
application: clear icon caches on shutdown

Currently, the icon caches are cleared in quit_mainloop(), which has
does not get invoked as of GLib 2.32, thus resulting in NautilusIconInfo
leaks. This commit moves the cache clearing call to shutdown().
Comment 2 Ernestas Kulik 2016-07-24 20:15:32 UTC 
Created attachment 332053 [details] [review]
application: clear icon caches on shutdown

Currently, the icon info caches are cleared in quit_mainloop(), which
does not get invoked as of GLib 2.32, thus resulting in NautilusIconInfo
leaks. This commit moves the cache clearing call to shutdown().
Comment 3 Carlos Soriano 2016-07-25 09:37:05 UTC 
Review of attachment 332053 [details] [review]:

whops, yes thanks!
Comment 4 Ernestas Kulik 2016-07-25 12:21:46 UTC 
Attachment 332053 [details] pushed as 6064bdc - application: clear icon caches on shutdown