After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769130 - libmisc: check doc_model is not NULL before disconnecting handler.
libmisc: check doc_model is not NULL before disconnecting handler.
Status: RESOLVED DUPLICATE of bug 774833
Product: evince
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-24 17:30 UTC by José Aliste
Modified: 2017-09-27 12:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libmisc: check doc_model is not NULL before disconnecting handler. (1.19 KB, patch)
2016-07-24 17:30 UTC, José Aliste 		reviewed Details | Review

Description José Aliste 2016-07-24 17:30:25 UTC 
This prevents some GTK-warnings that appear when closing a window
that has been created with "Open Copy" menu option
Comment 1 José Aliste 2016-07-24 17:30:40 UTC 
Created attachment 332039 [details] [review]
libmisc: check doc_model is not NULL before disconnecting handler.
Comment 2 Carlos Garcia Campos 2016-07-25 15:16:56 UTC 
Review of attachment 332039 [details] [review]:

::: libmisc/ev-page-action-widget.c
@@ +262,3 @@
         }
 
+        if (action_widget->signal_id > 0 && action_widget->doc_model) {

Shouldn't we do all this in ev_page_action_widget_set_model instead?
Comment 3 Germán Poo-Caamaño 2017-09-27 12:44:19 UTC 
Finally, it got applied a similar patch to this one.

https://git.gnome.org/browse/evince/commit/?id=116d8bc1d

*** This bug has been marked as a duplicate of bug 774833 ***