After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769089 - Fix gsettings uint64 testcase
Fix gsettings uint64 testcase
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gsettings
unspecified
Other All
: Normal normal
: ---
Assigned To: Allison Karlitskaya (desrt)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-07-22 15:55 UTC by Emilio Pozuelo Monfort
Modified: 2016-07-22 17:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use a uint64 to unpack a 64 bit value (961 bytes, patch)
2016-07-22 15:55 UTC, Emilio Pozuelo Monfort
committed Details | Review

Description Emilio Pozuelo Monfort 2016-07-22 15:55:28 UTC
This happens to pass on little endian because the value we are
retrieving is too small, but it fails on big endian and it would
fail everywhere if the value was large enough.

Fix the test case to unpack a 64bit value into a 64bit variable.
Comment 1 Emilio Pozuelo Monfort 2016-07-22 15:55:32 UTC
Created attachment 332011 [details] [review]
Use a uint64 to unpack a 64 bit value
Comment 2 Colin Walters 2016-07-22 17:02:17 UTC
Review of attachment 332011 [details] [review]:

LGTM.
Comment 3 Emilio Pozuelo Monfort 2016-07-22 17:20:49 UTC
Attachment 332011 [details] pushed as 38317cf - Use a uint64 to unpack a 64 bit value