After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769088 - filters: I can't tell the difference between my private and my work documents
filters: I can't tell the difference between my private and my work documents
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-07-22 15:44 UTC by Andreas Nilsson
Modified: 2017-04-05 05:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (25.55 KB, image/png)
2016-07-22 15:44 UTC, Andreas Nilsson
  Details
Screenshot with the fix (82.51 KB, image/png)
2017-04-04 15:59 UTC, Debarshi Ray
  Details
build, lokview: Bump minimum GJS requirement to 1.48.0 (1.71 KB, patch)
2017-04-04 18:09 UTC, Debarshi Ray
committed Details | Review

Description Andreas Nilsson 2016-07-22 15:44:01 UTC
Created attachment 332009 [details]
screenshot

So I have two Google accounts connected on my laptop.
One is my private account, and the other is my work account.

I was trying to find a document from work, so I wanted to restrict the filter/search to only the work account. Problem was, I couldn't easily identify what one of them was the work account, as both of them were called "Google".
Comment 1 Cosimo Cecchi 2017-04-02 00:46:34 UTC
I pushed a fix for this to master. We now also show the identity when there's more than one account for a given provider.
Comment 2 Debarshi Ray 2017-04-04 15:59:10 UTC
Created attachment 349244 [details]
Screenshot with the fix

Attaching a screenshot as requested in #gnome-design.
Comment 3 Andreas Nilsson 2017-04-04 16:07:55 UTC
So the Microsoft account in there is one long string, and that actually doesn't need the unique identifier, since it's the only Microsoft account on the system.

So I'm wondering if it's worth showing only the unique part of the identifier that is needed in each case:

Case 1 - Has only one account - show "Google"
Case 2 - Has one work and one private account on differnt domains - show "Google (domain.tld)"
Case 3 - Has two private accounts on same domain - show "Google (user@domain.tld)"
Comment 4 Cosimo Cecchi 2017-04-04 16:23:29 UTC
Thanks for testing! You actually found a bug -- it was not supposed to show the account identity when there's only one source with that name.
I agree with the other suggestion of only showing the domain if possible.
Comment 5 Debarshi Ray 2017-04-04 18:09:49 UTC
Created attachment 349259 [details] [review]
build, lokview: Bump minimum GJS requirement to 1.48.0

The last patch needs a newer gjs or needs to be written without Map.forEach.
Comment 6 Cosimo Cecchi 2017-04-04 18:18:39 UTC
Review of attachment 349259 [details] [review]:

Thanks!