After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769065 - Use GNOME standard "New Window" instead of "Open a New Window"
Use GNOME standard "New Window" instead of "Open a New Window"
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-22 00:29 UTC by Jeremy Bicha
Modified: 2016-08-21 04:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use GNOME standard "New Window" instead of "Open a New Window" (854 bytes, patch)
2016-07-22 00:29 UTC, Jeremy Bicha
committed Details | Review
Add some more .desktop keywords (865 bytes, patch)
2016-08-06 16:31 UTC, Jeremy Bicha
committed Details | Review

Description Jeremy Bicha 2016-07-22 00:29:14 UTC
gedit has desktop actions for "Open a New Window" and "Open a New Document".

By default, GNOME Shell has a default desktop action for "New Window".
Similarly, Epiphany has an action for "New Incognito Window".

For better conformity with the reset of GNOME, consider dropping the words
"Open a "

(Personally, I don't mind if everything uses "Open a New Window" but it
seems easier to just change gedit to match the GNOME default than to change
everything else.)
Comment 1 Jeremy Bicha 2016-07-22 00:29:17 UTC
Created attachment 331945 [details] [review]
Use GNOME standard "New Window" instead of "Open a New Window"
Comment 2 Ignacio Casal Quinteiro (nacho) 2016-07-22 06:41:06 UTC
Review of attachment 331945 [details] [review]:

Looks good.
Comment 3 Jeremy Bicha 2016-07-22 13:14:09 UTC
Thanks, but my git commit rights lapsed, so could you commit for me?

I guess I need to find someone to sponsor me to get that access again.
Comment 4 Jeremy Bicha 2016-08-06 16:31:13 UTC
Created attachment 332849 [details] [review]
Add some more .desktop keywords

I'm posting this here since it depends on the previous patch. Here's some
keywords Ubuntu has been adding to their packaging.

I don't currently have git commit rights, so feel free to push for me if
you accept the patches. Thanks!
Comment 5 Jeremy Bicha 2016-08-16 01:59:45 UTC
Hi, I'd like to see these get into GNOME 3.22 if it's not too late. You at least haven't pushed a 3.21.90 tarball yet…
Comment 6 Jeremy Bicha 2016-08-17 13:00:40 UTC
Hi, I have git commit rights now. Can I push one or both of these now?

I guess I would need to email the docs and translator lists too.

https://wiki.gnome.org/ThreePointTwentyone
Comment 7 Paolo Borelli 2016-08-20 10:40:13 UTC
Yes, please push both and send the mail
Comment 8 Jeremy Bicha 2016-08-21 04:20:37 UTC
Attachment 331945 [details] pushed as d9fcb96 - Use GNOME standard "New Window" instead of "Open a New Window"
Attachment 332849 [details] pushed as bb69192 - Add some more .desktop keywords