After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769057 - aacparse: Reject raw AAC why??
aacparse: Reject raw AAC why??
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-libav
1.9.1
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-21 20:17 UTC by m][sko
Modified: 2016-08-07 23:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description m][sko 2016-07-21 20:17:21 UTC
pipeline like(convert raw to adts)
..... ! avenc_libfdk_aac ! aacparse ! ..
don't work
as avenc_libfdk_aac 
SRC template: 'src'
    Availability: Always
    Capabilities:
      audio/mpeg
               channels: [ 1, 6 ]
                   rate: [ 4000, 96000 ]
            mpegversion: 4
          stream-format: raw
           base-profile: lc

and I don't know about voaacenc in raw mode

so why ??
Comment 1 Tim-Philipp Müller 2016-07-21 20:34:30 UTC
Please could you provide a GST_DEBUG=*parse*:6 debug log?
Comment 2 m][sko 2016-07-22 07:03:46 UTC
sorry I forget to add commit that create this problem:
https://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=fd261e10999a090555c149eca840c774aa147acc

so for raw format we get
GST_ERROR_OBJECT (parse, "Need codec_data for raw AAC");
Comment 3 Sebastian Dröge (slomo) 2016-07-22 07:15:45 UTC
That's an expected error in aacparse then. Do you have this gst-libav commit? https://cgit.freedesktop.org/gstreamer/gst-libav/commit/?id=832b42301d7be88cf80b2a0ba5ab54cf02393000

It's in 1.9.1.


The other question why the libfdk encoder is not disabled completely: https://cgit.freedesktop.org/gstreamer/gst-libav/tree/ext/libav/gstavaudenc.c#n792
Comment 4 m][sko 2016-07-22 16:42:23 UTC
I have latest master version of all gstreamer libraries.

libfdk simple provide better quality then voaacenc
https://bitbucket.org/xlazom00/gst/src/57a2897d0561/patch_1_8/gst_libav/debian/patches/?at=gst_1_8

Maybe we can enable libfdk with some configure --enable nonfree :)


this don't help
https://cgit.freedesktop.org/gstreamer/gst-libav/commit/?id=832b42301d7be88cf80b2a0ba5ab54cf02393000
Comment 5 m][sko 2016-07-22 16:56:07 UTC
log
http://pastebin.com/raw/fTW7Pz9j
Comment 6 m][sko 2016-07-22 17:00:32 UTC
this one is better
http://pastebin.com/raw/ig3WLhxH
Comment 7 Sebastian Dröge (slomo) 2016-07-25 05:58:57 UTC
(In reply to m][sko from comment #4)
> I have latest master version of all gstreamer libraries.
> 
> libfdk simple provide better quality then voaacenc
> https://bitbucket.org/xlazom00/gst/src/57a2897d0561/patch_1_8/gst_libav/
> debian/patches/?at=gst_1_8
> 
> Maybe we can enable libfdk with some configure --enable nonfree :)

It's general policy to not enable anything that requires external libraries in gst-libav. Instead there should be a native GStreamer element.

In the case of libfdk, some people apparently have their own ones for that which are not public but overall it should be a matter of a low number of hours of work to create a plugin for that when using GstAudioEncoder.

> this don't help
> https://cgit.freedesktop.org/gstreamer/gst-libav/commit/
> ?id=832b42301d7be88cf80b2a0ba5ab54cf02393000

You'll have to check then why there is no extradata in the AVCodecContext at that point, and also if it is maybe only available at a later time (when?).
Comment 8 Sebastian Dröge (slomo) 2016-08-07 13:55:42 UTC
You can find an fdk aac encoder and decoder element for GStreamer here now: https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/fdkaac
Comment 9 m][sko 2016-08-07 23:22:09 UTC
thx