Created attachment 331876 [details] [review]
patch

This is the schema as used in mutter's wip/tablet-protocol-v2 and gnome-control-center's wip/garnacho/wayland-tablet btw

Review of attachment 331876 [details] [review]:

> - Button mapping has been splitted into "primary" and "secondary"

"split"

Could you better describe the "secondary" button, such as mentioning that it's not the eraser? Mentioning an example pen (such as the Grip pen) that has both, and that the inking pen doesn't have a secondary button might also be nice.

Also mention that if the main control is a wheel, like in the airbrush pen, then the button is the primary button.

Looks good otherwise.

(In reply to Bastien Nocera from comment #3)
> Review of attachment 331876 [details] [review] [review]:
> 
> > - Button mapping has been splitted into "primary" and "secondary"
> 
> "split"

Doh :)

> 
> Could you better describe the "secondary" button, such as mentioning that
> it's not the eraser? Mentioning an example pen (such as the Grip pen) that
> has both, and that the inking pen doesn't have a secondary button might also
> be nice.
> 
> Also mention that if the main control is a wheel, like in the airbrush pen,
> then the button is the primary button.

Sure, attaching another one with improved descriptions there.

> 
> Looks good otherwise.

Thanks!

Created attachment 331879 [details] [review]
Patch. Updated button action descriptions

Review of attachment 331879 [details] [review]:

Looks good.

Thanks! The patch is now on master.