Created attachment 331833 [details] [review]
Adwaita: bring colors back in GtkCalendar "week of the year" column

Here is the patch with the proposed changes.

Thanks,
   Antonio

Thanks for spotting!
While I see the issue, the proposed solution looks a bit too much to me, what about dimming the highlight strip text color? 
What about something like `calendar.hilghlight { color: @borders; }` [<- in the inspector]? That way the highlight strip is differently colored than the dimmed calendar days (the ones from other months) so it should work, the contrast is a bit low anyway, what do you think?

The calendar theme scss had some other issues so I cleaned up the house a bit, I pushed the dimming too (not what I proposed though), please close if you think the issue has been addressed.

Created attachment 331846 [details]
Proposed change using color: @borders

I see your point about the new settings being a little intrusive.

However your proposed change does not really solve the issue, the same color will still be used for different things which are next one other, see the areas highlighted by the red circles in the attached screenshot.

The complication is that the css selector seems to affect *both* the top horizontal header and the "week of the year" column at the same time, that's why I thought that a background would work. A softer background maybe?

Thanks,
   Antonio

I replied before reading your last message, sorry.

I'll check the changes in the git repository and get back to you.

Thanks,
   Antonio

OK, even with the latest changes the issue pointed out in my latest screenshot is still there.

What about something along these lines?

diff --git a/gtk/theme/Adwaita/_common.scss b/gtk/theme/Adwaita/_common.scss
index 6181fc4..07ffa2a 100644
--- a/gtk/theme/Adwaita/_common.scss
+++ b/gtk/theme/Adwaita/_common.scss
@@ -3536,9 +3536,10 @@ calendar {
   }

   &.highlight {
-    color: $insensitive_fg_color;
+    color: $fg_color;
+    background-color: $insensitive_bg_color;

-    &:backdrop { color: $backdrop_insensitive_color; }
+    &:backdrop { color: $backdrop_text_color; background-color: $insensitive_bg_color; }
   }

   &:backdrop {


IMHO a background helps to differentiate the elements better, but I am no UI expert.


BTW I now realize that I also have no idea of what the :backdrop pseudo class is for :|

Thanks,
   Antonio

I'd really like to avoid using a background there, both week numbers and day names are accessory details at the end of the day, with a background they get more prominent than actual calendar days.

Widgets in an unfocused window get the `backdrop' pseudoclass, that name was picked to avoid confusion with `focus' (formerly `focused'), failing to some extent :-)

Whatever it is, there should be _something_ to differentiate the day/week# headers from the day numbers. Not including that - like in the screenshot https://bug769003.bugzilla-attachments.gnome.org/attachment.cgi?id=331846 which Antonio says is still current - is (sorry!) completely unintuitive and not good design.

If not a different background or text colour, then perhaps a pair of Separators forming a right angle?

    M  Tu  W   Th  F   Sa  Su
   --------------------------
26| 1   2  3   etc.
27|
28|

or even

Wk| M   Tu  W   Th  F   Sa  Su
--|--------------------------
26| 1    2  3   etc.
27|
28|

The gtkcalendar doesn't supporto full css theming, there are basically just colors, so I can't add additional lines, check out my latest commit though, the the week numbers and days are lighter then month days and darker then dimmed days, so there is a difference.

Hi Lapo, the difference between the dimmed days and the "highlight" is very subtle so we didn't notice it. The difference is a little more visible when switching from focused/unfocused but still quite confusing.

If the following is still too much, please let's use at least a darker gray for the highlight (and/or make the dimmed days even lighter?):

diff --git a/gtk/theme/Adwaita/_common.scss b/gtk/theme/Adwaita/_common.scss
index 6181fc4..e095818 100644
--- a/gtk/theme/Adwaita/_common.scss
+++ b/gtk/theme/Adwaita/_common.scss
@@ -3536,7 +3536,7 @@ calendar {
   }

   &.highlight {
-    color: $insensitive_fg_color;
+    color: $selected_bg_color;

     &:backdrop { color: $backdrop_insensitive_color; }
   }


Thanks again,
   Antonio

Created attachment 331982 [details]
Screenshot with more aggressivelly dimmed uninteresting days

Blue works for me, I'd rather increase contrast by dimming the uninteresting days as you suggest anyway, still for not giving too much importance to the highlight strips and for consistence with shell calendar, see the pic here.

And your last proposal works for me, the three elements (highlight, dimmed days, normal days) are easier to differentiate now.

Thanks,
   Antonio

Yeah, that looks far better, or even ideal :-)

Ok, pushing, thanks for helping out!