After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768987 - Nautilus crash when you connect / reconect to a remote bookmark
Nautilus crash when you connect / reconect to a remote bookmark
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Bookmarks
3.20.x
Other Linux
: Normal major
: 3.22
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-20 09:46 UTC by jeremy9856
Modified: 2016-07-25 08:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
query-editor: unref file in update_information_label() (1.19 KB, patch)
2016-07-21 08:49 UTC, Ernestas Kulik
committed Details | Review

Description jeremy9856 2016-07-20 09:46:37 UTC
Hello,

I'm on Fedora 24 and Nautilus crash when you connect / disconnect / reconnect to a remote bookmark :

sys:1: PyGIWarning: Nautilus was imported without specifying a version first. Use gi.require_version('Nautilus', '3.0') before import to ensure that the right version gets loaded.

(nautilus:12208): Gtk-WARNING **: Theme parsing error: <broken file>:1:0: Failed to import: La ressource dans « /org/gnome/libgd/tagged-entry/default.css » n'existe pas

(nautilus:12208): GLib-GIO-WARNING **: Failed to parse translated string 'Dossier personnel' for key 'home-icon-name' in schema 'org.gnome.nautilus.desktop': 0-1:unknown keyword

(nautilus:12208): GLib-GIO-WARNING **: Using untranslated default instead.
**
ERROR:nautilus-bookmark.c:351:nautilus_bookmark_connect_file: assertion failed: (!nautilus_file_is_gone (bookmark->details->file))
Aborted (core dumped)

Thanks !
Comment 1 Carlos Soriano 2016-07-20 09:48:48 UTC
Are you using any nautilus plugin? can you try uninstalling them?
Comment 2 Ernestas Kulik 2016-07-20 11:45:50 UTC
I can reproduce with master. This does not seem like an issue with a plugin.
Comment 3 jeremy9856 2016-07-20 12:01:53 UTC
(In reply to Carlos Soriano from comment #1)
> Are you using any nautilus plugin? can you try uninstalling them?

I use "gnome-terminal-nautilus". I uninstalled it, killall nautilus, retry and it still happen.
Comment 4 Ernestas Kulik 2016-07-21 08:49:42 UTC
Created attachment 331858 [details] [review]
query-editor: unref file in update_information_label()

window-slot binds with query-editor via a property, which results in
nautilus_query_editor_set_location() being called on construction and
location changes. That function in turn calls
update_information_label(), which takes a ref on the file, but does not
release it. This can result in a crash with remote bookmarks when
connecting/disconnecting or switching back and forth.

This commit fixes that by adding an unref to update_information_label().
Comment 5 Ernestas Kulik 2016-07-21 08:50:10 UTC
Jeremy, would you be able to test with the patch?
Comment 6 Carlos Soriano 2016-07-21 08:52:07 UTC
Review of attachment 331858 [details] [review]:

Excellent, thanks much Ernestas!
Can you push to 3.20 too?
Comment 7 Ernestas Kulik 2016-07-21 09:03:28 UTC
Attachment 331858 [details] pushed as 30dd00d - query-editor: unref file in update_information_label()
Comment 8 jeremy9856 2016-07-21 11:53:51 UTC
(In reply to Ernestas Kulik from comment #5)
> Jeremy, would you be able to test with the patch?

Thank you very much Ernestas ! I see that the patch is committed so do I still need to test Nautilus with it ? If yes, what is the best way, jhbuild ?
Comment 9 Ernestas Kulik 2016-07-21 12:01:34 UTC
(In reply to jeremy9856 from comment #8)
> (In reply to Ernestas Kulik from comment #5)
> > Jeremy, would you be able to test with the patch?
> 
> Thank you very much Ernestas ! I see that the patch is committed so do I
> still need to test Nautilus with it ? If yes, what is the best way, jhbuild ?

The change would have had to be made anyway, but I want to make sure that it indeed fixes this.

I tried and could not reproduce, thus I’m asking for a favor.

Using jhbuild is probably the easiest route you can take, so that’s a “yes”.
Comment 10 Carlos Soriano 2016-07-21 12:16:17 UTC
Jeremy, https://wiki.gnome.org/Newcomers/BuildGnome
Comment 11 jeremy9856 2016-07-22 15:30:14 UTC
I built Nautilus with jhbuild and it work. No more crash. Thanks ! Note that I didn't had to apply the patch it was already included. Can you confirm it because the version of the build is reported to be 3.19 ?

Is it possible to backport the patch to Nautilus 3.18 / 3.20 ?

Thanks !!!
Comment 12 Ernestas Kulik 2016-07-22 15:42:41 UTC
(In reply to jeremy9856 from comment #11)
> I built Nautilus with jhbuild and it work. No more crash. Thanks ! Note that
> I didn't had to apply the patch it was already included. Can you confirm it
> because the version of the build is reported to be 3.19 ?
> 
> Is it possible to backport the patch to Nautilus 3.18 / 3.20 ?
> 
> Thanks !!!

The reported version is correct, the master branch still parties like it’s 3.19. :)

I’ve already pushed the patch to the 3.20 branch; 3.18 won’t get any love, I’m afraid (Carlos, please confirm, I’m not up to speed with the policy).
Comment 13 jeremy9856 2016-07-22 15:48:59 UTC
(In reply to Ernestas Kulik from comment #12)
> I’ve already pushed the patch to the 3.20 branch

Great ! I'm on Fedora 24 with Nautilus 3.20 so it's perfect for me.

> 3.18 won’t get any love, I’m afraid

I think there is a lot of people still on 3.18 (and even older I'm sure) like Fedora 23 and Ubuntu Gnome 16.04. They could benefit from it but if it's not possible that's not a problem for me :)
Comment 14 Carlos Soriano 2016-07-25 07:19:05 UTC
(In reply to Ernestas Kulik from comment #12)
> (In reply to jeremy9856 from comment #11)
> > I built Nautilus with jhbuild and it work. No more crash. Thanks ! Note that
> > I didn't had to apply the patch it was already included. Can you confirm it
> > because the version of the build is reported to be 3.19 ?
> > 
> > Is it possible to backport the patch to Nautilus 3.18 / 3.20 ?
> > 
> > Thanks !!!
> 
> The reported version is correct, the master branch still parties like it’s
> 3.19. :)
> 
> I’ve already pushed the patch to the 3.20 branch; 3.18 won’t get any love,
> I’m afraid (Carlos, please confirm, I’m not up to speed with the policy).

3.18 is not a maintained version anymore, so no releases or backported patches are expected, apart of those enterprise distributions that support old versions or distros that do as well.

However backporting it will make their life easier, so feel free :)
Comment 15 Ernestas Kulik 2016-07-25 08:53:00 UTC
The 3.18 branch does not have the code that the patch applies to. I will guess that this bug does not apply to that version, either.